Repository navigation
fix(Anchor): honor disabled on links with non-trivial hrefs - #135
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Anchor with a real href ignores disabled: clicking still invokes its callback, bubbles, and follows the link.
Apply the existing button-props click guard to links, remove the href when disabled, and expose aria-disabled. Enabled links keep their native keyboard behavior and role.
Validation: the disabled-link regression failed before the fix; all 147 tests in 15 files now pass in Chromium, including enabled-link Space behavior, click propagation, href and role checks. TypeScript, changed-file lint/format, and the ESM/CJS/declaration/Popper builds pass. Full lint reports 11 existing formatting errors in unchanged files; it passes with only the formatter rule disabled. Local browser settings used cached Chromium and an IPv4 port because the default Windows IPv6 port was unavailable. The underlying build commands ran directly because Yarn is unavailable locally. Firefox/WebKit were not run.