Repository navigation
Resubscribe media queries when the target window changes - #103
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
useMediaQuery'stargetWindowwhile keeping the same query leaves the old window subscribed and returns its match value. Include the target window in the effect dependencies so the old listener is removed and the new window is observed.The regression fails before the fix and checks the new initial match, subsequent changes, and listener cleanup. All 89 tests pass (one existing skip), TypeScript, declarations and changed-file formatting pass. ESM/CJS compile and export checks pass using the underlying Babel CLI; the npm build wrappers mishandle quoted arguments on Windows. Real-browser matrix not run.