Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useMeasure): support custom measurers in order to support border-box and others #1603

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion src/useMeasure/index.dom.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {act, renderHook} from '@testing-library/react-hooks/dom';
import {useEffect} from 'react';
import {afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi} from 'vitest';
import {useMeasure} from '../index.js';
import {useMeasure, borderBoxMeasurer} from '../index.js';

describe('useMeasure', () => {
const observeSpy = vi.fn();
Expand Down Expand Up @@ -104,4 +104,44 @@ describe('useMeasure', () => {
expect(result.current[1]).toStrictEqual({current: div});
expect(result.current[0]).toStrictEqual(measures);
});

it('should set state by border-box sizing model', () => {
const div = document.createElement('div');
const {result} = renderHook(() => {
const measure = useMeasure<HTMLDivElement>(true, borderBoxMeasurer);

useEffect(() => {
measure[1].current = div;
});

return measure;
});

const measures = {
width: 9,
height: 9,
};

const entry = {
target: div,
contentRect: {width: 5, height: 5},
borderBoxSize: [
{
blockSize: 9,
inlineSize: 9,
},
],
contentBoxSize: {},
} as unknown as ResizeObserverEntry;

ResizeObserverSpy.mock.calls[0][0]([entry]);
expect(result.current[0]).toBeUndefined();

act(() => {
vi.advanceTimersByTime(1);
});

expect(result.current[1]).toStrictEqual({current: div});
expect(result.current[0]).toStrictEqual(measures);
});
});
23 changes: 22 additions & 1 deletion src/useMeasure/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,34 @@ export type Measures = {
height: number;
};

export type Measurer = (entry: ResizeObserverEntry) => Measures;

/**
* Measures ResizeObserverEntry by `content-box` sizing model
* Default measurer for `useMeasure`
*/
export const contentBoxMeasurer: Measurer = entry => ({
width: entry.contentRect.width,
height: entry.contentRect.height,
});

/**
* Measures ResizeObserverEntry by `border-box` sizing model
*/
export const borderBoxMeasurer: Measurer = entry => ({
height: entry.borderBoxSize[0].blockSize,
width: entry.borderBoxSize[0].inlineSize,
});

/**
* Uses ResizeObserver to track element dimensions and re-render component when they change.
*
* @param enabled Whether resize observer is enabled or not.
* @param observerEntryMatcher A custom measurer function to get measurements based on some box sizing model. `Content-box` sizing is default
*/
export function useMeasure<T extends Element>(
enabled = true,
measurer = contentBoxMeasurer,
): [Measures | undefined, MutableRefObject<T | null>] {
const [element, setElement] = useState<T | null>(null);
const elementRef = useHookableRef<T | null>(null, (v) => {
Expand All @@ -25,7 +46,7 @@ export function useMeasure<T extends Element>(

const [measures, setMeasures] = useState<Measures>();
const [observerHandler] = useRafCallback<UseResizeObserverCallback>((entry) => {
setMeasures({width: entry.contentRect.width, height: entry.contentRect.height});
setMeasures(measurer(entry));
});

useResizeObserver(element, observerHandler, enabled);
Expand Down
Loading