Skip to content

fix: isNameInFieldArray with names option #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
+30 −1
Merged

fix: isNameInFieldArray with names option #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/__tests__/toNestErrors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,35 @@ test('transforms flat object to nested object and shouldUseNativeValidation: tru
).toHaveBeenCalledWith(flatObject.name.message);
});

test('transforms flat object to nested object with names option', () => {
const result = toNestErrors(
{
username: {
type: 'custom',
message: 'error',
},
},
{
names: ['username', 'username.first'],
fields: {
username: {
name: 'username',
ref: { name: 'username' },
},
},
shouldUseNativeValidation: false,
},
);

expect(result).toEqual({
username: {
type: 'custom',
message: 'error',
ref: { name: 'username' },
},
});
});

test('transforms flat object to nested object with root error for field array', () => {
const result = toNestErrors(
{
Expand Down
2 changes: 1 addition & 1 deletion src/toNestErrors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ export const toNestErrors = <TFieldValues extends FieldValues>(
const isNameInFieldArray = (
names: InternalFieldName[],
name: InternalFieldName,
) => names.some((n) => n.startsWith(name + '.'));
) => names.some((n) => n.match(`^${name}\\.\\d+`));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n should contain number in field array.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuyaYoshioka this actual change broke validation for nested fields like below:

{
    user: { // user should have name or email
         name: '',
         email: '',
         passport: '' // passport should not be empty
    }
}

Yup validation for example supports this behavior, and @hookform/resolvers also supported this behavior until version 4.0.0.

Can we bring the previous solution back?