fix: use type to deciding whether to allow drag #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
这个 PR 行为感觉直接吧拖入功能ban调了？ 原生 其实也是支持拖入的，可以通过 onDrop 阻止默认事件来关闭这个功能， 现在来看 antd 这边输入 bug 当 feature 用了？ |
|
确实 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ant-design/ant-design#48300
antd use type to determine whether allow drag
https://github.com/ant-design/ant-design/blob/a125dfee8bd3e78f93fc5ab0eb6d4ce8e6b1cd79/components/upload/Upload.tsx#L434
https://github.com/ant-design/ant-design/blob/a125dfee8bd3e78f93fc5ab0eb6d4ce8e6b1cd79/components/upload/Upload.tsx#L442-L447
https://github.com/ant-design/ant-design/blob/a125dfee8bd3e78f93fc5ab0eb6d4ce8e6b1cd79/components/upload/Upload.tsx#L464-L466
https://github.com/ant-design/ant-design/blob/a125dfee8bd3e78f93fc5ab0eb6d4ce8e6b1cd79/components/upload/Upload.tsx#L476-L480
in Dragger also use type='drag'
https://github.com/ant-design/ant-design/blob/a125dfee8bd3e78f93fc5ab0eb6d4ce8e6b1cd79/components/upload/Dragger.tsx#L10-L14