-
-
Notifications
You must be signed in to change notification settings - Fork 605
feat: support classNames and styles #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thinkasany
wants to merge
2
commits into
react-component:master
Choose a base branch
from
thinkasany:cp-table
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+162
−13
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| import { render, fireEvent } from '@testing-library/react'; | ||
| import React from 'react'; | ||
| import Table, { TableProps } from '../src'; | ||
| describe('support classNames and styles', () => { | ||
| const columns: TableProps['columns'] = [ | ||
| { | ||
| title: 'title1', | ||
| dataIndex: 'a', | ||
| className: 'a', | ||
| key: 'a', | ||
| width: 100, | ||
| }, | ||
| { | ||
| title: 'title2', | ||
| dataIndex: 'b', | ||
| className: 'b', | ||
| key: 'b', | ||
| width: 100, | ||
| }, | ||
| { | ||
| title: 'title3', | ||
| dataIndex: 'c', | ||
| className: 'c', | ||
| key: 'c', | ||
| width: 200, | ||
| }, | ||
| { | ||
| title: 'Operations', | ||
| dataIndex: '', | ||
| className: 'd', | ||
| key: 'd', | ||
| render() { | ||
| return <a href="#">Operations</a>; | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const data = [ | ||
| { a: '123', key: '1' }, | ||
| { a: 'cdd', b: 'edd', key: '2' }, | ||
| { a: '1333', c: 'eee', d: 2, key: '3' }, | ||
| ]; | ||
| const commonTableProps = { | ||
| columns: columns, | ||
| rowClassName: (record, i) => `row-${i}`, | ||
| expandedRowRender: (record) => <p>extra: {record.a}</p>, | ||
| expandedRowClassName: (record, i) => `ex-row-${i}`, | ||
| className: "table", | ||
| title: () => <span>title</span>, | ||
| footer: () => <span>footer</span>, | ||
| }; | ||
| it('should support className and style', () => { | ||
| const testClassNames = { | ||
| section: 'test-section', | ||
| header: 'test-header', | ||
| title: 'test-title', | ||
| body: 'test-body', | ||
| footer: 'test-footer', | ||
| content: 'test-content', | ||
| item: 'test-item', | ||
| } | ||
| const testStyles = { | ||
| section: { background: 'red' }, | ||
| header: { background: 'blue' }, | ||
| title: { background: 'green' }, | ||
| body: { background: 'yellow' }, | ||
| footer: { background: 'pink' }, | ||
| content: { background: 'purple' }, | ||
| item: { background: 'orange' }, | ||
| } | ||
| const { container } = render( | ||
| <Table | ||
| {...commonTableProps} | ||
| classNames={testClassNames} | ||
| styles={testStyles} | ||
| data={data} | ||
| /> | ||
| ) | ||
| const section = container.querySelector('.rc-table-container'); | ||
| const title = container.querySelector('.rc-table-title'); | ||
| const footer = container.querySelector('.rc-table-footer'); | ||
| const content = container.querySelector('.rc-table-content'); | ||
| const item = container.querySelector('.rc-table-cell'); | ||
| expect(section).toHaveClass(testClassNames.section); | ||
| expect(section).toHaveStyle(testStyles.section); | ||
| expect(title).toHaveClass(testClassNames.title); | ||
| expect(title).toHaveStyle(testStyles.title); | ||
| expect(footer).toHaveClass(testClassNames.footer); | ||
| expect(footer).toHaveStyle(testStyles.footer); | ||
| expect(content).toHaveClass(testClassNames.content); | ||
| expect(content).toHaveStyle(testStyles.content); | ||
| expect(item).toHaveClass(testClassNames.item); | ||
| expect(item).toHaveStyle(testStyles.item); | ||
|
|
||
| const { container: scrollContainer } = render( | ||
| <Table | ||
| {...commonTableProps} | ||
| classNames={testClassNames} | ||
| styles={testStyles} | ||
| data={data} | ||
| scroll={{ y: 200 }} | ||
| /> | ||
| ) | ||
| const header = scrollContainer.querySelector('.rc-table-header'); | ||
| const body = scrollContainer.querySelector('.rc-table-body'); | ||
| expect(header).toHaveClass(testClassNames.header); | ||
| expect(header).toHaveStyle(testStyles.header); | ||
| expect(body).toHaveClass(testClassNames.body); | ||
| expect(body).toHaveStyle(testStyles.body); | ||
| }) | ||
| }) | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
样式属性应该是可选的
在
TitleProps接口中，新增的style属性被定义为必须项，这可能会导致现有使用 Panel 组件的地方出现兼容性问题。建议将其修改为可选属性。📝 Committable suggestion