Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should process 0 correctly when precision is 0 #390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boomler
Copy link
Contributor

@boomler boomler commented Jan 1, 2022

Fix the issue reported by:
ant-design/ant-design#33084 (comment)

@vercel
Copy link

vercel bot commented Jan 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/Grq5ac3Jwaze5dK5MnBSaSmmtCxu
✅ Preview: https://input-number-git-fork-boomler-fix-zero-react-component.vercel.app

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #390 (c8d2672) into master (d3de147) will increase coverage by 0.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
+ Coverage   97.76%   98.65%   +0.88%     
==========================================
  Files           9        9              
  Lines         448      445       -3     
  Branches      116      116              
==========================================
+ Hits          438      439       +1     
+ Misses         10        6       -4     
Impacted Files Coverage Δ
src/InputNumber.tsx 98.40% <100.00%> (ø)
src/utils/MiniDecimal.ts 99.26% <100.00%> (+2.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3de147...c8d2672. Read the comment docs.

@boomler
Copy link
Contributor Author

boomler commented Jan 12, 2022

Hi @zombieJ . This pr is to solve a bug caused by #385.
I think this bug is quit easy to happen, so let's see whether this is a good solution or you have other suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants