Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding store import cleanup #53

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Adding store import cleanup #53

merged 1 commit into from
Jun 20, 2024

Conversation

Southporter
Copy link
Contributor

I was running into some memory leaks after setting up some host function imports. This allows the Store to deinit the memory allocated when adding host imports.

rdunnington
rdunnington approved these changes Jun 20, 2024
View reviewed changes
Copy link
Owner

@rdunnington rdunnington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm sure there are other places with memory leaks as well, I keep forgetting to hook up leak detection to the main wasm-test suite.

@rdunnington rdunnington merged commit 2ff4f4b into rdunnington:main Jun 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdunnington rdunnington rdunnington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Southporter @rdunnington