Timesync with new interfaces #428
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [OCDM] Added new interfaces as discussed in the specification. * [REVIEW] Update after review with Doug. * [REVIEW] Update after review * Update after review * [OCDM] Move the subsamples to a simple array. * [OCDM] OCDM Enhancements * Review Comments from Doug * More review comments * Correct Return Values Co-authored-by: Santhosh Ramani <[email protected]>
* [IBluetooth] Update with advertising functionality * [IBluetooth] Further changes Added Device lookup by type Added ForgetDevice Moved IsUUIDSupported to common class and renamed to IsServiceSupported Removed dev comments * [IBluetooth] Further fixes Deprecated IsBonded and added IsPaired Inline-implemented the depracated Device to call Device(..., LE_PUBLIC) Made IsAdvertising const Syntax fixes * [Bluetooth.json] Update reflecing C++ changes * [Bluetooth] Group enums together * [Bluetooth] Update names * [Bluetooth] Make sure all methods are verbs * [IBluetooth] Interface id is short int * Add status listeners to the state events * [BluetoothControl] Add pretty names to methods
…ll-typo IDisplayinfo: fix typo
TimeSync: update time property usage as deprecated
…al#227) * Creating GitHub Action to build ThunderInterfaces * Update Build ThunderInterfaces.yml
…ws (rdkcentral#232) * Update and rename Build ThunderInterfaces.yml to Build ThunderInterfaces on Linux.yml * Create Build ThunderInterfaces on Windows.yml * Updating artifacts paths * Updating checkout and output paths * Changing project and solution paths Apparently devenv can't open solution if not run from the very same folder.. * Prepare for PR and merge * Optimizing runtime no outside actions necessary * More name changes
Referencing this action inside ThunderNanoServicesRDK breaks since the owner of this repo is different
* [WARNINGS] Resolve the tool generator warnings. * [COMPOSITION] Add an interface to be used by the COmpositor to share between client and server. * [COMPOSITION] Enable the COmpositionBuffer (Interface and reference implementation)
* [FIX] Make sure the windows build succeeds again :-) * [PORTABILITY] Drop the preprocessor in favour of a default defined type (uintptr_t) * [FIX] Search path needs to change to the interfaces, if you move the definitions.
…owser plugin (rdkcentral#233) Co-authored-by: Pierre Wielders <[email protected]>
* [PackMan] Introduction of PackageManager interface * [PackMan] Adjusted license info * [PackMan] More license changes
…mplementation. (rdkcentral#240) Avoid to much copy-pasting during the use of value points (Range handling)
* [SPLIT] Make sure the definitions get their own space. The definitions should be also from header file perspective a seperate package. It is already a seperate library but it was mangled with the interfaces. This PR will properly seperate them. interfaces -> Interface definitions (Pure Virtual Interfaces) definitions -> Reference impletmentations of an interface, and enum definitions (text conversions). * Update CMakelist.txt
…tral#272) Reason for change: TTS thunder plugin missing "speechrate" Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: vdinak240 <[email protected]> Co-authored-by: Pierre Wielders <[email protected]>
Reason for change: Enhancements to PersistentStore plugin to support Scope, Time To Live. Use of the RPC COM and JSON RPC interfaces. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <[email protected]>
RDK-45037 : Secure Storage Thunder Plugin
…rdkcentral#333) Reason for change: add additional resolutions in DeviceInfo json file in Thunder 4.2 Test Procedure: Build and verify Risks: Low
…dkcentral#278) * REFPLTV-1561 - Added support for value "PI" in DeviceInfo.json file REFPLTV-1561 RDKServices: Some of the APIs in DeviceInfo plugin are returning ERROR_GENERAL message Reason for change: Support is added for RPI. Test Procedure: Ensure the DeviceInfo plugin functionality. Risks: low. Signed-off-by: [email protected] * Update DeviceInfo.json for make and modelid support for RPI --------- Co-authored-by: Pierre Wielders <[email protected]>
…ranch (rdkcentral#284) * REFPLTV-1561 - Added support for value "PI" in DeviceInfo.json file REFPLTV-1561 RDKServices: Some of the APIs in DeviceInfo plugin are returning ERROR_GENERAL message Reason for change: Support is added for RPI. Test Procedure: Ensure the DeviceInfo plugin functionality. Risks: low. Signed-off-by: [email protected] * Update DeviceInfo.json for make and modelid support for RPI * Update DeviceInfo.json to fix REFPLTV-1561 devicetype property support REFPLTV-1561 RDKServices: Some of the APIs in DeviceInfo plugin are returning ERROR_GENERAL message Reason for change: Support is added for RPI devicetype property. Test Procedure: Ensure the DeviceInfo plugin functionality for devicetype property. Value for devicetype will be fetched from device.properties file for DEVICE_TYPE field for rpi. Risks: low. Signed-off-by: [email protected] --------- Co-authored-by: Pierre Wielders <[email protected]>
Reason for change: "Manufacturer" name is empty in pioneer 2K Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <[email protected]>
Rdktv 29897 r4 4
RDK-48604: New UserSettings Thunder Plugin
Reason for change: return Sky_CP instead of Amlogic_Inc Test Procedure: None Risks: None Signed-off-by: ramkumar_prabaharan <[email protected]>
RDKTV-31447 LlamaGlass make name shows Amlogic_Inc
Reason for change: Lowercase for consistency with previous json spec. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <[email protected]>
DELIA-66115: ScopeType enum case (rdkcentral#371)
… and results are inconsistent across Xumo platforms Reason for change: DeviceInfo properties are returning "ERROR_GENERAL" Error: DeviceInfo properties are returning "ERROR_GENERAL" Test Procedure: Verify the DeviceInfo properties response Risks: Low Signed-off-by:AkshayKumar_Gampa <[email protected]>
DELIA-66154: Some DeviceInfo properties are returning "ERROR_GENERAL"…
The first part went in ProxyStubGenerator rdkcentral/ThunderTools#150
…onfiguration based on tr-181 Device:2.Device.Time.
|
biju-vi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 3 commits
March 19, 2025 14:58
… methods are supposed to be pure virtual functions(= 0). Then we need to implement them in both TimeSync and Chrony plugins. We need a proper way to extend this so that implementaion should be done in Chrony plugin alone. For the time being, the work around is to use {return 0;}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new interfaces for getting time sync status and setting time configuration based on tr-181 Device:2.Device.Time.
1 . GetStatus - To get the status whether time has synced or not. TSStatus is the enum for it
2. SetConfiguration - To set tr-181 configuration Device:2.Device.Time. TimeSyncConfiguration is the configuration dtructure for it