Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default logs signal to trace #753

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Default logs signal to trace #753

wants to merge 10 commits into from

Conversation

pkumbh631
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Nv-Delle1416
Nv-Delle1416 previously approved these changes Mar 14, 2025
Copy link

github-actions bot commented Mar 19, 2025

Code Coverage

Package Line Rate Health
core.main.src 0%
core.sdk.src.api.distributor 84%
device.thunder_ripple_sdk.src 17%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.firebolt 2%
core.sdk.src.extn.ffi 80%
core.sdk.src.api.manifest 89%
device.thunder_ripple_sdk.src.processors 13%
core.sdk.src.api.gateway 64%
core.sdk.src.extn 82%
core.main.src.processor 0%
core.sdk.src.api 80%
device.mock_device.src 53%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.firebolt.handlers 9%
core.tdk.src.gateway 100%
core.main.src.state.cap 42%
core.main.src.service 31%
core.sdk.src.utils 50%
core.sdk.src.api.observability 57%
core.main.src.broker.thunder 37%
core.sdk.src.api.firebolt 79%
core.main.src.service.extn 40%
core.main.src.state 22%
device.thunder.src 0%
core.main.src.broker 56%
core.main.src.processor.storage 0%
core.sdk.src.extn.client 88%
core.tdk.src.utils 0%
core.main.src.bootstrap.manifest 0%
core.sdk.src.api.device 78%
core.main.src.bootstrap 0%
distributor.general.src 2%
openrpc_validator.src 67%
device.thunder_ripple_sdk.src.events 4%
core.main.src.service.apps 46%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.client 67%
core.main.src.bootstrap.extn 0%
core.sdk.src.processor 0%
core.sdk.src.framework 76%
core.main.src.utils 27%
core.main.src.broker.test 90%
Summary 46% (19448 / 42689)

Minimum allowed line rate is 43%

Current coverage:46% exceeds coverage threshold. Coverage threshold will be updated automatically to reflect to the latest coverage when this pr is merged to main branch.

@@ -31,42 +29,3 @@ impl LoadDeviceManifestStep {
r.expect("Need valid Device Manifest")
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to include these changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also more device manifest changes below...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The load steps had to be moved from device_manifest to device to all the loading logic to be available to the initialization logic in logger. TL;DR: intentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants