-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPPL-2687 : Move RPC Handler for Advertising.id, config, reset to Distributor Extn #743
base: main
Are you sure you want to change the base?
Conversation
The Blackduck flag is not a problem. However, is line 55 (hairy string) sensitive? |
feat: added get_new_internal_with_appid method for internal communication between extensions
feat: added new method of ad targetting
Minimum allowed line rate is Current coverage:46% exceeds coverage threshold. Coverage threshold will be updated automatically to reflect to the latest coverage when this pr is merged to main branch. |
@@ -46,6 +46,8 @@ use ripple_sdk::{ | |||
|
|||
#[rpc(server)] | |||
pub trait Capability { | |||
#[method(name = "ripple.capabilitypermitcheck")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you call this ripple.isPermitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the minor comment
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist