Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPPL-2687 : Move RPC Handler for Advertising.id, config, reset to Distributor Extn #743

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

nnaveen979
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@nnaveen979 nnaveen979 requested review from satlead, pahearn73 and a team February 27, 2025 16:42
@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/743/rdkcentral/Ripple

  • Commit: cbd789b

Report detail: gist'

@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/743/rdkcentral/Ripple

  • Commit: cbd789b

Report detail: gist'

@mhughesacn
Copy link

The Blackduck flag is not a problem. However, is line 55 (hairy string) sensitive?

Copy link

github-actions bot commented Mar 25, 2025

Code Coverage

Package Line Rate Health
core.main.src.service 31%
device.thunder_ripple_sdk.src 17%
distributor.general.src 2%
core.main.src.utils 27%
core.main.src.service.apps 46%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.bootstrap.extn 0%
core.sdk.src.api.firebolt 79%
core.sdk.src.api.observability 73%
core.tdk.src.gateway 100%
core.main.src.broker 57%
core.sdk.src.api.gateway 62%
core.main.src.broker.thunder 37%
core.main.src 0%
core.sdk.src.extn.ffi 80%
core.main.src.firebolt 2%
core.main.src.bootstrap 0%
device.thunder.src 0%
core.main.src.service.extn 40%
core.main.src.state 22%
core.sdk.src.api.distributor 84%
core.main.src.broker.test 90%
device.mock_device.src 54%
core.main.src.processor 0%
core.sdk.src.processor 0%
core.sdk.src.api 80%
device.thunder_ripple_sdk.src.bootstrap 0%
core.sdk.src.utils 50%
core.tdk.src.utils 0%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors 13%
device.thunder_ripple_sdk.src.events 4%
openrpc_validator.src 67%
core.sdk.src.extn 82%
core.sdk.src.api.manifest 89%
core.sdk.src.framework 76%
device.thunder_ripple_sdk.src.client 67%
core.sdk.src.api.device 78%
core.main.src.state.cap 42%
core.main.src.bootstrap.manifest 0%
core.sdk.src.extn.client 88%
core.main.src.processor.storage 0%
core.main.src.firebolt.handlers 9%
Summary 46% (19498 / 42409)

Minimum allowed line rate is 43%

Current coverage:46% exceeds coverage threshold. Coverage threshold will be updated automatically to reflect to the latest coverage when this pr is merged to main branch.

@@ -46,6 +46,8 @@ use ripple_sdk::{

#[rpc(server)]
pub trait Capability {
#[method(name = "ripple.capabilitypermitcheck")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call this ripple.isPermitted

Copy link
Collaborator

@satlead satlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the minor comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants