RDKBWIFI-36: WiFi7 Datamodel Implementation #561

siddharth-nair-dtdl · 2025-08-28T09:20:05Z

Reason for change: Adding in the datamodels related to WiFi7 for OneWiFi component
Test Procedure: Verify build is successfull and check if DMs are updated properly on Device
Risks: Medium
Priority: P2

Reason for change: Adding in the datamodels related to WiFi7 for OneWiFi component Test Procedure: Verify build is successfull and check if DMs are updated properly on Device Risks: Medium Priority: P2 Signed-off-by: Siddharth Nair <[email protected]>

CLAassistant · 2025-08-28T09:20:12Z

All committers have signed the CLA.

github-actions · 2025-08-28T09:20:18Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

pradeeptakdas · 2025-08-28T15:21:49Z

Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-5414

Pavlo-Uvarov · 2025-09-01T08:52:06Z

config/TR181-WiFi-USGv2.XML

+                                              <syntax>bool</syntax>
+                                              <writable>false</writable>
+                                            </parameter>
+                                         <parameter>


Please align with the rest of "parameters".

Pavlo-Uvarov · 2025-09-01T09:07:40Z

source/core/wifi_ctrl.c

+    //Get the parameter values from HAL
+    wifi_hal_getApMld(&hal_apmld, &APMLD_Count);
+
+    if (APMLD_Count > 0)


To check if it's not null instead of number of AP MLD, because later in the code the same check is being done. Also in case there is 0 AP MLD it will be written in g_wifi_mgr->apmld_countand it will return successfully after freeing hal_apmld.

Suggested change

if (APMLD_Count > 0)

if (hal_apmld)

Pavlo-Uvarov · 2025-09-01T09:14:38Z

source/core/wifi_ctrl.c

+
+        while (idx < APMLD_Count)
+        {
+            memcpy(g_wifi_mgr->apmld_info[idx].common_info.mld_addr,hal_apmld->common_info.mld_addr,6);


Can we replace this 6 with some constant or definition?

Pavlo-Uvarov · 2025-09-01T09:37:47Z

source/dml/tr_181/ml/cosa_wifi_dml.c

+        }
+        *pInsNumber = nIndex + 1;
+        g_radio_instance_num = nIndex + 1;
+        last_radio_change = AnscGetTickInSeconds();


Please add some debug print, same as in Radio_GetEntry.
Please add debug prints to other newly added functions as well.

Pavlo-Uvarov · 2025-09-01T09:39:07Z

source/dml/tr_181/ml/cosa_wifi_dml.c

+        ANSC_HANDLE                 hInsContext
+    )
+{
+       return TRUE;


Suggested change

return TRUE;

UNREFERENCED_PARAMETER(hInsContext);

return TRUE;

Also consider adding one extra bool variable to update it once update_dml_apmld_info is being called to return a valid result.

Pavlo-Uvarov · 2025-09-01T09:46:18Z

source/dml/tr_181/ml/cosa_wifi_dml.c

+
+    if(AnscEqualString(ParamName,"MLDMACAddress", TRUE))
+    {
+        char mac_str[18];


Consider adding new constant for MAC string size or use the one available in <pwd>/lib/osa/os_types.h

yes, the OS_MACSTR_SZ const

Pavlo-Uvarov · 2025-09-01T10:21:02Z

source/dml/tr_181/ml/cosa_wifi_dml.c

+        *puLong = pcfg->ru_id;
+        return TRUE;
+    }
+    else if( AnscEqualString(ParamName,"DisabledSubChannels", TRUE))


Also it would be nice to have definitions for those string literals - consider adding those definitions.

mateuszCieslak-GL · 2025-09-01T15:30:38Z

source/core/wifi_ctrl.c

+        if (hal_apmld) {
+            free (hal_apmld);
+        }


this if check won't be needed after applying Pavlo's comment from above (free still will).

mateuszCieslak-GL · 2025-09-01T15:51:25Z

source/core/wifi_ctrl.c

+            memcpy(g_wifi_mgr->apmld_info[idx].common_info.mld_addr,hal_apmld->common_info.mld_addr,6);
+            g_wifi_mgr->apmld_info[idx].affiliated_ap_number_of_entries = hal_apmld[idx].affiliated_ap_number_of_entries;
+            g_wifi_mgr->apmld_info[idx].sta_mld_num_entries =  hal_apmld[idx].sta_mld_num_entries;


please consider just copying pointers instead of manual deep copy,
It's less complicated (and - more important, faster!) and hal_apmd is already allocated in wifi_hal_getApMld,

Suggested change

memcpy(g_wifi_mgr->apmld_info[idx].common_info.mld_addr,hal_apmld->common_info.mld_addr,6);

g_wifi_mgr->apmld_info[idx].affiliated_ap_number_of_entries = hal_apmld[idx].affiliated_ap_number_of_entries;

g_wifi_mgr->apmld_info[idx].sta_mld_num_entries = hal_apmld[idx].sta_mld_num_entries;

g_wifi_mgr->apmld_info[idx] = hal_apmld[idx];

g_wifi_mgr->apmld_info[idx].common_info.mld_addr = hal_apmld->common_info.mld_addr;

and then remove
free (hal_apmld);

this memory will be freed when g_wifi_mgr->apmld_info will not be needed.

mateuszCieslak-GL · 2025-09-01T15:53:21Z

source/dml/dml_webconfig/dml_onewifi_api.c

    wifi_util_info_print(WIFI_DMCLI,"Exit %s:%d \n",__func__, __LINE__);
    return TRUE;
 }
+UINT get_dml_wifi7_radio_modes()


is this needed? Can't get_wifidb_wifi7_radio_modes() be called directly? if it can, please call it directly.

mateuszCieslak-GL · 2025-09-01T15:57:27Z

source/dml/dml_webconfig/dml_onewifi_api.c

+int update_dml_apmld_info()
+{
+    if(get_wifidb_apmld_info() == 0)
+    {
+        return 0;
+    }
+    else
+    {
+        return -1;
+    }
+}


Same as above.
If additional layer is needed please shorten it:

Suggested change

int update_dml_apmld_info()

{

if(get_wifidb_apmld_info() == 0)

{

return 0;

}

else

{

return -1;

}

}

int update_dml_apmld_info()

{

return get_wifidb_apmld_info();

}

If not, please remove it and call get_wifidb_apmld_info() directly.

mateuszCieslak-GL · 2025-09-01T15:59:36Z

source/dml/tr_181/ml/cosa_wifi_dml.c

+    UNREFERENCED_PARAMETER(hInsContext);
+    wifi_radio_operationParam_t *wifiRadioOperParam = NULL;
+
+    if ( nIndex < (UINT)get_num_radio_dml() )


get_num_radio_dml already returns UINT, no need for cast.

mateuszCieslak-GL · 2025-09-01T16:11:10Z

source/dml/tr_181/ml/cosa_wifi_dml.c

+
+    if(AnscEqualString(ParamName,"MLDMACAddress", TRUE))
+    {
+        char mac_str[18];


yes, the OS_MACSTR_SZ const

mateuszCieslak-GL · 2025-09-01T16:16:44Z

source/dml/tr_181/ml/cosa_wifi_dml.c

+        *pInsNumber=nIndex+1;
+        return (ANSC_HANDLE)(&pcfg->affiliated_ap[nIndex]);


I don't understand your idea here. Were you trying to do this:

Suggested change

*pInsNumber=nIndex+1;

return (ANSC_HANDLE)(&pcfg->affiliated_ap[nIndex]);

*pInsNumber=nIndex+1;

return (ANSC_HANDLE)(&pcfg->affiliated_ap[*pInsNumber]);

?

gsathish86 mentioned this pull request Aug 29, 2025

RDKBWIFI-36: WiFi7 Datamodel Implementation rdkcentral/rdk-wifi-hal#327

Open

siddharth-nair-dtdl marked this pull request as ready for review August 29, 2025 05:11

siddharth-nair-dtdl requested a review from a team as a code owner August 29, 2025 05:11

Pavlo-Uvarov reviewed Sep 1, 2025

View reviewed changes

mateuszCieslak-GL reviewed Sep 1, 2025

View reviewed changes

	return TRUE;
	UNREFERENCED_PARAMETER(hInsContext);
	return TRUE;

		*pInsNumber=nIndex+1;
		return (ANSC_HANDLE)(&pcfg->affiliated_ap[nIndex]);

RDKBWIFI-36: WiFi7 Datamodel Implementation #561

Are you sure you want to change the base?

RDKBWIFI-36: WiFi7 Datamodel Implementation #561

Uh oh!

Conversation

siddharth-nair-dtdl commented Aug 28, 2025

Uh oh!

CLAassistant commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

pradeeptakdas commented Aug 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pavlo-Uvarov Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateuszCieslak-GL Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateuszCieslak-GL Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateuszCieslak-GL Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateuszCieslak-GL Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateuszCieslak-GL Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Aug 28, 2025 •

edited

Loading

Pavlo-Uvarov Sep 1, 2025 •

edited

Loading

mateuszCieslak-GL Sep 1, 2025 •

edited

Loading

mateuszCieslak-GL Sep 1, 2025 •

edited

Loading

mateuszCieslak-GL Sep 1, 2025 •

edited

Loading

mateuszCieslak-GL Sep 1, 2025 •

edited

Loading

mateuszCieslak-GL Sep 1, 2025 •

edited

Loading