RDKCOM-5330: RDKBDEV-3190 add WIFI_HAL_VERSION_3 compile time check #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Code currently relies on WIFI_HAL_VERSION_3 with no alternative available. Test Procedure: Sanity. Signed-off-by: Andre McCurdy <[email protected]> (cherry picked from commit c50dc6f)
|
it is better to add this check on Makefile |
vivianecordeiro-sky
requested changes
Jun 26, 2025
|
I would also remove any code reference to WIFI_HAL_VERSION_3 since it must be defined |
narendradandu
approved these changes
Jul 10, 2025
|
All contributors have signed the CLA ✍️ ✅ |
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
|
|
Nikita-Hakai
pushed a commit
to Nikita-Hakai/OneWifi
that referenced
this pull request
Oct 28, 2025
Increase the max size of SDU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change:
Code currently relies on WIFI_HAL_VERSION_3 with no alternative available.
Test Procedure: Sanity.
Signed-off-by: Andre McCurdy [email protected]
(cherry picked from commit c50dc6f)