Skip to content

Upgrades construction/materials constants/methods #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brgix merged 10 commits into from
Sep 12, 2025
Merged

Upgrades construction/materials constants/methods #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4f9e853
Upgrades construction/materials constants/methods
brgix Sep 8, 2025
8076dde
Sets aside (thick) insulation check
brgix Sep 8, 2025
dce1ced
Extends 5Zone case tests (uprate, then derate)
brgix Sep 8, 2025
5a59131
Catches failed Default Construction Set 'get'
brgix Sep 9, 2025
6a438f3
Trims down spec tests
brgix Sep 9, 2025
586e16e
Moves TBD constants to psi.rb
brgix Sep 9, 2025
046e6a5
Reverts TBD constants move
brgix Sep 9, 2025
f13c036
Turns down the log 'volume' with interzone subs
brgix Sep 10, 2025
892cca9
Pulls OSut v080 gem
brgix Sep 10, 2025
628f15f
Fixes when cloned uprated constructions are needed
brgix Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/measures/tbd/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>tbd_measure</name>
<uid>8890787b-8c25-4dc8-8641-b6be1b6c2357</uid>
<version_id>7a2d773a-7a50-4c69-aa1f-93ed796e9ace</version_id>
<version_modified>2025-08-15T13:39:31Z</version_modified>
<version_id>0e1528a0-a176-4d46-82d9-d2da40c0abd7</version_id>
<version_modified>2025-09-11T11:27:14Z</version_modified>
<xml_checksum>99772807</xml_checksum>
<class_name>TBDMeasure</class_name>
<display_name>Thermal Bridging and Derating - TBD</display_name>
Expand Down Expand Up @@ -499,7 +499,7 @@
<filename>geo.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>EF3BA8F7</checksum>
<checksum>5AB24CFB</checksum>
</file>
<file>
<filename>geometry.rb</filename>
Expand All @@ -523,7 +523,7 @@
<filename>psi.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>71AED953</checksum>
<checksum>29905280</checksum>
</file>
<file>
<filename>tbd.rb</filename>
Expand All @@ -541,13 +541,13 @@
<filename>ua.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>022F6D10</checksum>
<checksum>0CC24D82</checksum>
</file>
<file>
<filename>utils.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>3CD8019A</checksum>
<checksum>6940D006</checksum>
</file>
<file>
<filename>version.rb</filename>
Expand Down
19 changes: 10 additions & 9 deletions lib/measures/tbd/resources/geo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,23 +310,24 @@ def properties(surface = nil, argh = {})
end

unless surface.construction.empty?
construction = surface.construction.get.to_LayeredConstruction
lc = surface.construction.get.to_LayeredConstruction

unless construction.empty?
construction = construction.get
lyr = insulatingLayer(construction)
lyr[:index] = nil unless lyr[:index].is_a?(Numeric)
lyr[:index] = nil unless lyr[:index] >= 0
lyr[:index] = nil unless lyr[:index] < construction.layers.size
unless lc.empty?
lc = lc.get
lyr = insulatingLayer(lc)

if lyr[:index]
surf[:construction] = construction
if lyr[:index].is_a?(Integer) && lyr[:index].between?(0, lc.numLayers - 1)
surf[:construction] = lc
# index: ... of layer/material (to derate) within construction
# ltype: either :massless (RSi) or :standard (k + d)
# r : initial RSi value of the indexed layer to derate
surf[:index] = lyr[:index]
surf[:ltype] = lyr[:type ]
surf[:r ] = lyr[:r ]
else
surf[:index] = nil
surf[:ltype] = nil
surf[:r ] = 0.0
end
end
end
Expand Down
192 changes: 108 additions & 84 deletions lib/measures/tbd/resources/psi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,103 +1355,103 @@ def inputs(s = {}, e = {}, argh = {})
##
# Thermally derates insulating material within construction.
#
# @param id [#to_s] surface identifier
# @param id [#to_sym] surface identifier
# @param [Hash] s TBD surface parameters
# @option s [#to_f] :heatloss heat loss from major thermal bridging, in W/K
# @option s [#to_f] :net surface net area, in m2
# @option s [Numeric] :heatloss heat loss from major thermal bridging, in W/K
# @option s [Numeric] :net surface net area, in m2
# @option s [:massless, :standard] :ltype indexed layer type
# @option s [#to_i] :index deratable construction layer index
# @option s [#to_f] :r deratable layer Rsi-factor, in m2•K/W
# @option s [Integer] :index deratable construction layer index
# @option s [Numeric] :r deratable layer Rsi-factor, in m2•K/W
# @param lc [OpenStudio::Model::LayeredConstruction] a layered construction
#
# @return [OpenStudio::Model::Material] derated (cloned) material
# @return [OpenStudio::Model::OpaqueMaterial] derated (cloned) material
# @return [nil] if invalid input (see logs)
def derate(id = "", s = {}, lc = nil)
mth = "TBD::#{__callee__}"
m = nil
id = trim(id)
kys = [:heatloss, :net, :ltype, :index, :r]
ck1 = s.is_a?(Hash)
ck2 = lc.is_a?(OpenStudio::Model::LayeredConstruction)
return mismatch("id" , id, cl6, mth) if id.empty?
return mismatch("#{id} surface" , s , cl1, mth) unless ck1
return mismatch("#{id} construction", lc, cl2, mth) unless ck2
cl = OpenStudio::Model::LayeredConstruction
return mismatch("lc", lc, cl, mth) unless lc.respond_to?(NS)
return mismatch("id", id, String, mth) unless id.respond_to?(:to_sym)

id = trim(id)
nom = lc.nameString
return invalid("id", mth, 1) if id.empty?
return mismatch(nom, lc, cl, mth) unless lc.is_a?(cl)
return mismatch("#{nom} surface", s, Hash, mth) unless s.is_a?(Hash)

if nom.downcase.include?(" tbd")
log(WRN, "Won't derate '#{nom}': tagged as derated (#{mth})")
return m
end

kys.each do |k|
tag = "#{id} #{k}"
return hashkey(tag, s, k, mth, ERR) unless s.key?(k)
return hashkey(tag, s, k, mth) unless s.key?(k)

case k
when :heatloss
return mismatch(tag, s[k], Numeric, mth) unless s[k].respond_to?(:to_f)
return zero(tag, mth, WRN) if s[k].to_f.abs < 0.001
when :net, :r
return mismatch(tag, s[k], Numeric, mth) unless s[k].respond_to?(:to_f)
return negative(tag, mth, 2, ERR) if s[k].to_f < 0
return zero(tag, mth, WRN) if s[k].to_f.abs < 0.001
when :index
return mismatch(tag, s[k], Numeric, mth) unless s[k].respond_to?(:to_i)
return negative(tag, mth, 2, ERR) if s[k].to_f < 0
else # :ltype
when :ltype
next if [:massless, :standard].include?(s[k])
return invalid(tag, mth, 2, ERR)
end
end
return invalid(tag, mth, 2)
when :index
return mismatch(tag, s[k], Integer, mth) unless s[k].is_a?(Integer)
return invalid(tag, mth, 2) unless s[k].between?(0, lc.numLayers - 1)
else
return mismatch(tag, s[k], Numeric, mth) unless s[k].is_a?(Numeric)
next if k == :heatloss

if lc.nameString.downcase.include?(" tbd")
log(WRN, "Won't derate '#{id}': tagged as derated (#{mth})")
return m
return negative(tag, mth, 2) if s[k] < 0
return zero(tag, mth) if s[k].abs < 0.001
end
end

model = lc.model
ltype = s[:ltype ]
index = s[:index ].to_i
net = s[:net ].to_f
r = s[:r ].to_f
u = s[:heatloss].to_f / net
ltype = s[:ltype]
index = s[:index]
net = s[:net]
r = s[:r]
u = s[:heatloss] / net
loss = 0
de_u = 1 / r + u # derated U
de_r = 1 / de_u # derated R
de_u = 1 / r + u # derated insulating material U
de_r = 1 / de_u # derated insulating material R

if ltype == :massless
m = lc.getLayer(index).to_MasslessOpaqueMaterial
m = lc.getLayer(index).to_MasslessOpaqueMaterial
return invalid("#{id} massless layer?", mth, 0) if m.empty?
m = m.get
up = ""
up = "uprated " if m.nameString.downcase.include?(" uprated")
m = m.clone(model).to_MasslessOpaqueMaterial.get
m.setName("#{id} #{up}m tbd")
de_r = 0.001 unless de_r > 0.001
loss = (de_u - 1 / de_r) * net unless de_r > 0.001
m.setThermalResistance(de_r)

m = m.get
up = m.nameString.downcase.include?(" uprated") ? "uprated " : ""
m = m.clone(model).to_MasslessOpaqueMaterial.get
m.setName("#{id} #{up}m tbd")

de_r = RMIN unless de_r > RMIN
loss = (de_u - 1 / de_r) * net unless de_r > RMIN

unless m.setThermalResistance(de_r)
return invalid("Can't derate #{id}: RSi#{de_r.round(2)}", mth)
end
else
m = lc.getLayer(index).to_StandardOpaqueMaterial
m = lc.getLayer(index).to_StandardOpaqueMaterial
return invalid("#{id} standard layer?", mth, 0) if m.empty?
m = m.get
up = ""
up = "uprated " if m.nameString.downcase.include?(" uprated")
m = m.clone(model).to_StandardOpaqueMaterial.get
m.setName("#{id} #{up}m tbd")
k = m.thermalConductivity

if de_r > 0.001
d = de_r * k

unless d > 0.003
d = 0.003
k = d / de_r
k = 3 unless k < 3
loss = (de_u - k / d) * net unless k < 3
end
else # de_r < 0.001 m2•K/W
d = 0.001 * k
d = 0.003 unless d > 0.003
k = d / 0.001 unless d > 0.003
loss = (de_u - k / d) * net

m = m.get
up = m.nameString.downcase.include?(" uprated") ? "uprated " : ""
m = m.clone(model).to_StandardOpaqueMaterial.get
m.setName("#{id} #{up}m tbd")

d = m.thickness
k = (d / de_r).clamp(KMIN, KMAX)
d = (k * de_r).clamp(DMIN, DMAX)

loss = (de_u - k / d) * net unless d / k > RMIN

unless m.setThermalConductivity(k)
return invalid("Can't derate #{id}: K#{k.round(3)}", mth)
end

m.setThickness(d)
m.setThermalConductivity(k)
unless m.setThickness(d)
return invalid("Can't derate #{id}: #{(d*1000).to_i}mm", mth)
end
end

if m && loss > TOL
Expand Down Expand Up @@ -1941,14 +1941,38 @@ def process(model = nil, argh = {})
ids = windows.keys + doors.keys + skylights.keys
end

unless ids.include?(i)
log(ERR, "Orphaned subsurface #{i} (mth)")
adj = nil

unless ids.include?(i) # adjacent sub surface?
sb = model.getSubSurfaceByName(i)

if sb.empty?
log(DBG, "Orphaned subsurface #{i} (#{mth})?")
else
sb = sb.get
adj = sb.adjacentSubSurface

if adj.empty?
log(DBG, "Orphaned sub #{i} (#{mth})?")
end
end

next
end

window = windows.key?(i) ? windows[i] : {}
door = doors.key?(i) ? doors[i] : {}
skylight = skylights.key?(i) ? skylights[i] : {}
if adj
window = windows.key?(i) ? windows[i] : {}
door = doors.key?(i) ? doors[i] : {}
skylight = skylights.key?(i) ? skylights[i] : {}
else
window = windows.key?(i) ? windows[i] : {}
door = doors.key?(i) ? doors[i] : {}
skylight = skylights.key?(i) ? skylights[i] : {}
end

# window = windows.key?(i) ? windows[i] : {}
# door = doors.key?(i) ? doors[i] : {}
# skylight = skylights.key?(i) ? skylights[i] : {}

sub = window unless window.empty?
sub = door unless door.empty?
Expand Down Expand Up @@ -2939,12 +2963,12 @@ def process(model = nil, argh = {})
up = argh[:uprate_walls] || argh[:uprate_roofs] || argh[:uprate_floors]
uprate(model, tbd[:surfaces], argh) if up

# Derated (cloned) constructions are unique to each deratable surface.
# Unique construction names are prefixed with the surface name,
# and suffixed with " tbd", indicating that the construction is
# henceforth thermally derated. The " tbd" expression is also key in
# avoiding inadvertent derating - TBD will not derate constructions
# (or rather layered materials) having " tbd" in their OpenStudio name.
# A derated (cloned) construction and (cloned) insulating layer are unique
# to each deratable surface. Unique construction and material names are
# prefixed with the surface name, and suffixed with " tbd", indicating that
# the construction is henceforth thermally derated. The " tbd" expression
# is also key in avoiding inadvertent sequential derating - TBD will not
# derate a construction/material pair having " tbd" in their OpenStudio name.
tbd[:surfaces].each do |id, surface|
next unless surface.key?(:construction)
next unless surface.key?(:index)
Expand Down Expand Up @@ -3138,9 +3162,9 @@ def exit(runner = nil, argh = {})
argh[:uprate_walls ] = false unless argh.key?(:uprate_walls )
argh[:uprate_roofs ] = false unless argh.key?(:uprate_roofs )
argh[:uprate_floors] = false unless argh.key?(:uprate_floors)
argh[:wall_ut ] = 5.678 unless argh.key?(:wall_ut )
argh[:roof_ut ] = 5.678 unless argh.key?(:roof_ut )
argh[:floor_ut ] = 5.678 unless argh.key?(:floor_ut )
argh[:wall_ut ] = UMAX unless argh.key?(:wall_ut )
argh[:roof_ut ] = UMAX unless argh.key?(:roof_ut )
argh[:floor_ut ] = UMAX unless argh.key?(:floor_ut )
argh[:wall_option ] = "" unless argh.key?(:wall_option )
argh[:roof_option ] = "" unless argh.key?(:roof_option )
argh[:floor_option ] = "" unless argh.key?(:floor_option )
Expand Down
Loading