-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made some changes so this runs on 4.12+ cluster #64
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly rollback to use the OpenShift Pipeline checks again, adapt to the post_ci to use the main branch approach.
Thanks for your contributions @afouladi7!
until: crds.resources|length > 0 | ||
retries: 30 | ||
delay: 10 | ||
# - name: Adapt to the openshift_cluster_version LESS than 4.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afouladi7 why we are removing these checks? I've tested in 4.13 and worked like a charm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you running this on BM? I tested this on both BM and RHPDS on 4.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VMs (Hetzner + libvirt + 4.13) and I'll do it in RHPDS 4.11 as well :)
bootstrap/roles/ocp4-install-pipelines/templates/task-s2i-java-11.yaml.j2
Show resolved
Hide resolved
@@ -47,6 +47,39 @@ | |||
namespace: "{{ ocp4_demo_pipeline_namespace }}" | |||
type: Opaque | |||
|
|||
# - name: Get Service Account objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed (check the main branch) grabbing directly the secret token itself, instead of grepping for the sa pipeline token. Shall we move to the main branch proposal and avoid to use the shell commands?
run without failure.
changing the ubi to 8.8
doc edits for ACS policy change and Fedora prerequisite installs
We cannot specify both keycloak and dex as SSO providers. When I tried enabling just keycloak the gitops-operator hit some segfault errors so switch to just using dex for now
Fixing ArgoCD CR: Cannot specify both keycloak and dex
Using Keycloak breaks the gitops operator as of v1.9.1
Removing update to add keycloak for now
Adding Quay to doc and status.sh
adding the argo dex fix
Tell it to ignore cert validation for the gogs url
Create trust_quay_from_another_cluster.md
adding charges from org
Adding all these changes to ensure this demo still runs on 4.12+ cluster. Also tested on 4.13.