Skip to content

Allow passing string-type target to Resource.update #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbw wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow passing string-type target to Resource.update #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59623da
Add support for string-type target to Resource.update
rbw Mar 6, 2021
de274eb
Use patch in Resource.update
rbw Mar 6, 2021
d46585c
Add update-by-id test
rbw Mar 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions pysnow/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,14 @@ def update(self, query, payload):
if not isinstance(payload, dict):
raise InvalidUsage("Update payload must be of type dict")

record = self.get(query=query).one()

self._url = self._get_custom_endpoint(record["sys_id"])
return self._get_response("PUT", data=json.dumps(payload))
if isinstance(query, str):
sys_id = query
else:
record = self.get(query=query).one()
sys_id = record["sys_id"]

self._url = self._get_custom_endpoint(sys_id)
return self._get_response("PATCH", data=json.dumps(payload))

def delete(self, query):
"""Deletes a record
Expand Down
21 changes: 19 additions & 2 deletions tests/test_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,23 @@ def test_create(self):
self.assertEquals(type(response.one()), dict)
self.assertEquals(response.one(), self.record_response_create)

@httpretty.activate
def test_update_sysid(self):
""":meth:`update` should return a dictionary of the updated record"""

sys_id = self.record_response_get_one[0]["sys_id"]

httpretty.register_uri(
httpretty.PATCH,
self.mock_url_builder_sys_id,
body=get_serialized_result(self.record_response_update),
status=200,
content_type="application/json",
)

updated = self.resource.update(sys_id, self.record_response_update)
self.assertEquals(self.record_response_update["attr1"], updated["attr1"])

@httpretty.activate
def test_update(self):
""":meth:`update` should return a dictionary of the updated record"""
Expand All @@ -543,7 +560,7 @@ def test_update(self):
)

httpretty.register_uri(
httpretty.PUT,
httpretty.PATCH,
self.mock_url_builder_sys_id,
body=get_serialized_result(self.record_response_update),
status=200,
Expand Down Expand Up @@ -772,7 +789,7 @@ def test_response_update(self):
)

httpretty.register_uri(
httpretty.PUT,
httpretty.PATCH,
self.mock_url_builder_sys_id,
body=get_serialized_result(self.record_response_update),
status=200,
Expand Down