This repository was archived by the owner on Jul 3, 2025. It is now read-only.
fix(netcore): allow for utls-aware structured logs#73
Merged
bassosimone merged 3 commits intomainfrom Mar 14, 2025
Merged
Conversation
This diff modifies `Network` in a backwards compatible way to add a new optionally-nil field named `TLSEngine`. This field is now the preferred way for creating a new `TLSConn` while the previous `NewTLSClientConn` field, which is still supported, has now become deprecated. The problem we want to solve is that of making sure the name of the TLS engine and the parrot being used are inside of the structured logs. With `TLSEngine`, which is an interface, we know that. With `NewTLSClientConn`, we don't know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff modifies
Networkin a backwards compatible way to add a new optionally-nil field namedTLSEngine.This field is now the preferred way for creating a new
TLSConnwhile the previousNewTLSClientConnfield, which is still supported, has now become deprecated.The problem we want to solve is that of making sure the name of the TLS engine and the parrot being used are inside of the structured logs.
With
TLSEngine, which is an interface, we know that, via theName()andParrot()methods.With
NewTLSClientConn, we don't know, hence we set both to"unknown".