Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify logic for rpath, the comma syntax is supported by all compilers #2497

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Simplify logic for rpath, the comma syntax is supported by all compilers #2497

merged 2 commits into from
Jan 15, 2025

Conversation

eregon
Copy link
Member

@eregon eregon commented Jan 15, 2025

@eregon eregon requested a review from mislav January 15, 2025 10:35
@eregon eregon mentioned this pull request Jan 15, 2025
Merged
@eregon
Copy link
Member Author

eregon commented Jan 15, 2025

I also added a test for macOS.
unstub cc failed there https://github.com/rbenv/ruby-build/actions/runs/12786681573/job/35644238555?pr=2497#step:4:22 , I'm not sure why, maybe it's OK to not unstub there?

mislav
mislav approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for this cleanup; I've pushed some tweaks to the test and in a separate PR I am improving the unstub $PROGRAM functionality to output more information about what failed.

@eregon eregon merged commit 5d0b957 into rbenv:master Jan 15, 2025
4 checks passed
@eregon eregon deleted the cleanup-rpath branch January 15, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eregon @mislav