Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon using --show-progress for wget #2304

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Abandon using --show-progress for wget #2304

merged 1 commit into from
Nov 9, 2023

Conversation

mislav
Copy link
Member

@mislav mislav commented Nov 9, 2023

It seems like there exist platforms that have wget which does not support the --show-progress option. This reverts to using wget in its default verbose mode where a progress bar and bunch more information are printed to stderr.

Fixes #2301
Followup to #2230

-> wget -O ruby-3.2.2.tar.gz https://cache.ruby-lang.org/pub/ruby/3.2/ruby-3.2.2.tar.gz
--2023-11-08 23:59:46--  https://cache.ruby-lang.org/pub/ruby/3.2/ruby-3.2.2.tar.gz
Resolving cache.ruby-lang.org (cache.ruby-lang.org)... 151.101.193.178, 151.101.1.178, 151.101.65.178, ...
Connecting to cache.ruby-lang.org (cache.ruby-lang.org)|151.101.193.178|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 20467023 (20M) [application/x-tar]
Saving to: ‘ruby-3.2.2.tar.gz’

ruby-3.2.2.tar.gz        100%[========================================>]  19.52M  30.3MB/s    in 0.6s    

2023-11-08 23:59:48 (30.3 MB/s) - ‘ruby-3.2.2.tar.gz’ saved [20467023/20467023]

Users can set an environment variable to opt into less verbose wget behavior that still shows a simple progress bar:

export RUBY_BUILD_WGET_OPTS="-nv --show-progress"

It seems like there exist platforms that have wget which does not
support the `--show-progress` option. This reverts to using wget in its
default verbose mode where a progress bar and bunch more information are
printed to stderr.
@mislav mislav merged commit 270ecd0 into master Nov 9, 2023
6 checks passed
@mislav mislav deleted the fix-wget branch November 9, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on Alpine as BusyBox wget does not support --show-progress
1 participant