fix(service/back): avoid populating history on back

rbalet · Nov 5, 2024 · 46c239a · 46c239a
1 parent 25526ac
commit 46c239a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,7 +14,7 @@ jobs:
         with:
           node-version: 20
           cache: 'npm'
-      - run: npm i
+      - run: npm ci
       # - name: lint
       #   run: npm run lint
       # - run: npm run build
@@ -43,7 +43,7 @@ jobs:
         with:
           node-version: 20
           cache: 'npm'
-      - run: npm i
+      - run: npm ci
       - run: npm run build
       - name: release
         run: cd dist/ngx-back-button && npx semantic-release --branches main

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-back-button",
-  "version": "18.2.0",
+  "version": "18.2.1",
   "license": "MIT",
   "author": "Raphael Balet",
   "maintainers": [

diff --git a/projects/ngx-back-button/package.json b/projects/ngx-back-button/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-back-button",
-  "version": "18.2.0",
+  "version": "18.2.1",
   "license": "MIT",
   "author": "Raphael Balet",
   "maintainers": [

diff --git a/projects/ngx-back-button/src/lib/ngx-back-button.service.ts b/projects/ngx-back-button/src/lib/ngx-back-button.service.ts
@@ -11,6 +11,8 @@ export class NgxBackButtonService {
   private _rootUrl!: string // Default Fallback in case we do not have any navigation history
   private _fallbackPrefix!: string // Always added in case of a Fallback (Useful when used within other libraries)
 
+  private _navigatingBack = false
+
   constructor(
     @Inject(NgxBackButtonServiceProvider) _config: NgxBackButtonServiceConfig,
 
@@ -23,7 +25,9 @@ export class NgxBackButtonService {
     this._router.events
       .pipe(filter((e): e is NavigationEnd => e instanceof NavigationEnd))
       .subscribe((event) => {
-        this._history.push(event.urlAfterRedirects)
+        if (!this._navigatingBack) this._history.push(event.urlAfterRedirects)
+
+        this._navigatingBack = false
       })
   }
 
@@ -33,6 +37,7 @@ export class NgxBackButtonService {
    * @return Boolean: True === Had an history to go back to
    */
   back(fallback?: string): boolean {
+    this._navigatingBack = true
     const record = this._history.pop()
 
     if (this._history.length > 0) {