migrate(sdk): user preferences to ConnectRPC #1214
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
usePreferenceshook from REST client to Connect RPCBehavior Changes
Fetching Behavior
Before (REST client):
useEffectwithfetchPreferencesin dependency array - could cause infinite loops if not memoized correctlyuseStatefor preferencesfetchPreferences()returnedPromise<V1Beta1Preference[] | undefined>- required await[](no error state exposed)After (Connect RPC):
useQuerywithenabled: autoFetch- prevents infinite loopsfetchPreferences()returnsvoid- triggers refetch via React Queryerrorif exposed)Update Behavior
Before (REST client):
setPreferences(getFormattedData(data))Promise<V1Beta1Preference[] | undefined>[](silently failed)After (Connect RPC):
listCurrentUserPreferencesPromise<void>- doesn't return the data (fetched automatically)create(CreateCurrentUserPreferencesRequestSchema, { bodies })Caching & Synchronization
Before:
After:
Status Management
Before:
After:
Key Improvements