refactor: edit org using connectRPC #1197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
whoAbhishekSah
force-pushed
the
connectrpc_ui_migration_org_edit
branch
from
2261dc8 to
fa8801b
Compare
rohilsurana
reviewed
Oct 13, 2025
Pull Request Test Coverage Report for Build 18460394609Details
💛 - Coveralls |
rsbh
reviewed
Oct 13, 2025
| async function onSubmit(data: OrgUpdateSchema) { | ||
| try { | ||
| const payload: Frontierv1Beta1OrganizationRequestBody = { | ||
| const payload = { |
There was a problem hiding this comment.
use create method with protobuf and updateOrganizationRequestSchema to create payload.
Instead of relying on the TS type for build-time safety, we will get runtime safety with protobuf.
And we already have protobuf loaded, so let's use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate org edit screen to Connect RPC
Replace swagger API call with Connect RPC + TanStack Query in organization edit form.
Changes:
api.frontierServiceUpdateOrganization()withuseMutation(FrontierServiceQueries.updateOrganization)