Skip to content

feat (calendar): add dateInfo #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat (calendar): add dateInfo #546

wants to merge 9 commits into from

Conversation

@paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented Nov 20, 2025 •
edited
Loading

Description

Add dateInfo for calendar date.
Change snake case to camel case in calendar css.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes, no bug fixes just code improvements)
  • Chore (changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, etc))
  • Test (adding missing tests or correcting existing tests)
  • Improvement (Improvements to existing code)
  • Other (please specify)

How Has This Been Tested?

Manual and unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (.mdx files)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Screenshots (if appropriate):

Screenshot 2025-11-20 at 4 24 12 PM

Related Issues

NA

@vercel
Copy link

vercel bot commented Nov 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
apsara Ready Ready Preview Comment Nov 26, 2025 8:30am

@paanSinghCoder paanSinghCoder changed the title Feat/date info calendar feat (calendar): add dateInfo Nov 21, 2025
rohanchkrabrty
rohanchkrabrty requested changes Nov 26, 2025
View reviewed changes
packages/raystack/components/calendar/calendar.tsx Outdated
showTooltip?: boolean;
tooltipMessages?: { [key: string]: any };
tooltipMessages?: Record<string, ReactNode>;
dateInfo?: Record<string, ReactNode>;
Copy link
Contributor

@rohanchkrabrty rohanchkrabrty Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to take a function for additional information.

(date) => ReactNode

we can use this to render addition information. User will just pass a function

Copy link
Contributor

@rohanchkrabrty rohanchkrabrty Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can do both. function and object both

Copy link
Contributor Author

@paanSinghCoder paanSinghCoder Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do both to make it more flexible. Updated the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsbh rsbh Awaiting requested review from rsbh

@rohanchkrabrty rohanchkrabrty Awaiting requested review from rohanchkrabrty

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paanSinghCoder @rohanchkrabrty