[desktop_glfw] fix InitPlatform crash caused by glfwCreateWindow... #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...returning NULL. This was causing a crash few lines later. Refs: raysan5#4801 (comment) Partially-fixes: raysan5#4801
|
@sleeptightAnsiC looks good, thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...returning NULL. This was causing a crash few lines later.
This was described in detail here: #4801 (comment)
Note that rcore_web.c has a very similar code path, but unlike in rcore_desktop_glfw.c, WEB version checks for null in all branches before doing anything.
Tested on native x86_64 Linux, and on x86_64 MacOS 13.6.9 running in VM. With GLFW in both cases.
Partially-fixes: #4801