Skip to content

[core] Complement OpenURL implementation for SDL #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Oct 25, 2023
Merged

[core] Complement OpenURL implementation for SDL #3460

merged 1 commit into from Oct 25, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2023

Changes

  1. Complements OpenURL missing the avoid [\'] character check (L1018) on rcore_desktop_sdl.c (R902-R904). And also the security warning (R896-R899).

Environment

Changes tested on Linux (Mint 21.1 64-bit).

Edits

1: added line marks.

@ghost
Copy link
Author

ghost commented Oct 24, 2023

@raysan5 Perhaps it would be a good idea to also add the security warning (R896-R899) to the cheatsheet/ raylib.h (L1062).

@raysan5 raysan5 merged commit b0c0f2e into raysan5:master Oct 25, 2023
@raysan5
Copy link
Owner

raysan5 commented Oct 25, 2023

@ubkp thanks for the review! Actually, I did not implement it because I didn't know if it could be managed by SDL_OpenURL internally, but it seems it's up to the user.

@ghost ghost deleted the fix/openurl-sdl branch October 25, 2023 11:07
@ghost
Copy link
Author

ghost commented Oct 25, 2023

@raysan5 Sorry to ask again, but do you think the security warning (R896-R899) should be added the cheatsheet/ raylib.h (L1062) too? It looks important.

@raysan5
Copy link
Owner

raysan5 commented Oct 25, 2023

@ubkp I prefer to avoid those long comments in the cheatsheets, maybe it can be simplified to just "basic URL security checks" at the end or no need to add it. In any case, if a inappropiate url is provided a tracelog message is shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant