Skip to content

Update apple-notes extension #20138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

Conversation

fanhefeng
Copy link
Contributor

@fanhefeng fanhefeng commented Jun 30, 2025

Description

Screencast

Checklist

- feat Add Chinese Pinyin method to search  notes
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: apple-notes Issues related to the apple-notes extension labels Jun 30, 2025
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @tumispro @ron-myers @mathieudutour @StevenRCE0 @SKaplanOfficial @tylerwince @thomaslombart @xilopaint @ridemountainpig @teemusuvinen @saldanaj97 @andreaselia you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@fanhefeng fanhefeng marked this pull request as ready for review June 30, 2025 03:42
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added Chinese Pinyin search support to the Apple Notes extension through pinyin-pro integration, enabling search using both Chinese characters and pinyin input methods.

  • The CHANGELOG.md entry needs to follow the template format by adding {PR_MERGE_DATE} to the title
  • New dependency [email protected] added for Chinese language support
  • Removed keepSectionOrder property from List component which may affect note section ordering
  • User can now search notes using Chinese characters or pinyin across titles, snippets, folders, and tags

3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Comment on lines 46 to 47
searchBarPlaceholder="Search notes by title, folder, description, tags, or accessories"
filtering={{ keepSectionOrder: true }}
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Update searchBarPlaceholder to mention Chinese/pinyin search support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to mention Chinese/pinyin support in the searchBar?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ;)

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit a793ad9 into raycast:main Jun 30, 2025
2 checks passed
@fanhefeng fanhefeng deleted the ext/apple-notes branch June 30, 2025 08:57
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/raycast/apple-notes

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@fanhefeng).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

@pernielsentikaer pernielsentikaer self-assigned this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: apple-notes Issues related to the apple-notes extension extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants