-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update apple-notes extension #20138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apple-notes extension #20138
Conversation
- feat Add Chinese Pinyin method to search notes - Initial commit
Thank you for your contribution! 🎉 🔔 @tumispro @ron-myers @mathieudutour @StevenRCE0 @SKaplanOfficial @tylerwince @thomaslombart @xilopaint @ridemountainpig @teemusuvinen @saldanaj97 @andreaselia you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added Chinese Pinyin search support to the Apple Notes extension through pinyin-pro integration, enabling search using both Chinese characters and pinyin input methods.
- The CHANGELOG.md entry needs to follow the template format by adding
{PR_MERGE_DATE}
to the title - New dependency
[email protected]
added for Chinese language support - Removed
keepSectionOrder
property from List component which may affect note section ordering - User can now search notes using Chinese characters or pinyin across titles, snippets, folders, and tags
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
searchBarPlaceholder="Search notes by title, folder, description, tags, or accessories" | ||
filtering={{ keepSectionOrder: true }} | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Update searchBarPlaceholder to mention Chinese/pinyin search support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to mention Chinese/pinyin support in the searchBar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Looks good to me, approved 🔥
Published to the Raycast Store: |
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@fanhefeng). |
Description
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder