[data] Split out long running scaling test #54045
Merged
+123
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Owen <[email protected]>
srinathk10
approved these changes
Jun 25, 2025
bveeramani
approved these changes
Jun 25, 2025
| del batch | ||
| del ds | ||
| # Force GC to free up object store memory | ||
| gc.collect() |
There was a problem hiding this comment.
You need to add the if __name__ = "__main__" stuff for this test to actually run
| from ray.data import DataContext | ||
| from ray.data._internal.util import GiB | ||
| from ray.data.tests.test_arrow_block import ( | ||
| parquet_dataset_single_column_gt_2gb, # noqa: F401 |
There was a problem hiding this comment.
Also move this? I think it's only used by the the one test
Signed-off-by: Matthew Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Test
test_arrow_blockhas become flakey, often failing because it times out ontest_arrow_batch_gt_2gbwhich is a scaling test to see if the arrow code works with a single 2gb batch. This splits out that test into its own suite to see if that will reduce the likelihood of a timeout (limit should be 180s). If this does not work, the next step will be to try running this on a larger worker.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.