-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] support batch_format for Sort and Aggregate #48287
base: master
Are you sure you want to change the base?
Conversation
a2b2bc3
to
0045e27
Compare
Hi @scottjlee, could you take a look when you have time? Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, have a suggestion on how we can set the batch_format without having it explicitly set at Dataset
level.
python/ray/data/_internal/logical/rules/inherit_batch_format.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/logical/rules/inherit_batch_format.py
Outdated
Show resolved
Hide resolved
6fc8b80
to
bc0caf0
Compare
bc0caf0
to
e3f14e7
Compare
python/ray/data/_internal/logical/rules/inherit_batch_format.py
Outdated
Show resolved
Hide resolved
81097ac
to
f39498b
Compare
Signed-off-by: Xingyu Long <[email protected]>
Signed-off-by: Xingyu Long <[email protected]>
Signed-off-by: Xingyu Long <[email protected]>
Signed-off-by: Xingyu Long <[email protected]>
Signed-off-by: Xingyu Long <[email protected]>
f39498b
to
e4f5009
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @xingyu-long !
python/ray/data/_internal/logical/rules/inherit_batch_format.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/logical/rules/inherit_batch_format.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Xingyu Long <[email protected]>
20a24af
to
afeb03c
Compare
Signed-off-by: Xingyu Long <[email protected]>
Why are these changes needed?
While we calling
xxx.map_groups(..., batch_format="...")
, we may invoke sort function and creating empty blocks which still uses pyarrow by default. And, when we invoke another sort call on top of it, we will hitAttributeError: 'DataFrame' object has no attribute 'num_rows'
since we uses first block type. (However, we may have different blocks). See more details in #46748Related issue number
Close #46748
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.