Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add demands info to GCS debug state #48115

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

rkooo567
Copy link
Contributor

Why are these changes needed?

Example:

GcsAutoscalerStateManager: 
- last_seen_autoscaler_state_version_: 0
- last_cluster_resource_state_version_: 18
- pending demands:
	{CPU: 4, } * 88

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 requested a review from a team as a code owner October 21, 2024 04:01
@rkooo567 rkooo567 added the go add ONLY when ready to merge, run all tests label Oct 21, 2024
@rkooo567
Copy link
Contributor Author

rkooo567 commented Oct 25, 2024

@jjyao comment addressed can we merge this before next release?

@jjyao
Copy link
Collaborator

jjyao commented Oct 25, 2024

@rkooo567 if we merge today, it should go out with the next release.

@rkooo567 rkooo567 enabled auto-merge (squash) October 25, 2024 21:00
@rkooo567 rkooo567 merged commit 0bd32d6 into ray-project:master Oct 25, 2024
6 checks passed
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants