[data] Remove ray.kill in ActorPoolMapOperator #47752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Chen <[email protected]>
Signed-off-by: Hao Chen <[email protected]>
raulchen
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
stephanie-wang and
omatthew98
as code owners
Signed-off-by: Hao Chen <[email protected]>
bveeramani
approved these changes
Sep 19, 2024
| del self._num_tasks_in_flight[actor] | ||
| del self._actor_locations[actor] |
There was a problem hiding this comment.
Could we add a note that we intend to refactor this with the pause API at some point?
Comment on lines
650
to
651
| assert actor not in self._num_tasks_in_flight | ||
| assert actor not in self._actor_locations |
There was a problem hiding this comment.
Why we're asserting after modified the state?
There was a problem hiding this comment.
the assert is for a different dict.
it's to make sure the actor handle is not being ref'ed by any of these 3 dicts
Signed-off-by: Hao Chen <[email protected]>
Signed-off-by: Hao Chen <[email protected]>
Signed-off-by: Hao Chen <[email protected]>
Signed-off-by: Hao Chen <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
With ray-project#47396, now Ray Core can automatically restarts an actor when needing to resubmit tasks. This doesn't work with `ray.kill`-ed actors. This PR removes ray.kill and let ref counting garbage-collect the actors. --------- Signed-off-by: Hao Chen <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
raulchen
pushed a commit
that referenced
this pull request
Nov 9, 2024
#47752 introduced a minor, silent issue in test_map. I stumbled across it because a linter I'm using complained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
With #47396, now Ray Core can automatically restarts an actor when needing to resubmit tasks.
This doesn't work with
ray.kill-ed actors.This PR removes ray.kill and let ref counting garbage-collect the actors.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.