Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix some flakey CI tests. #47729

Closed
wants to merge 2 commits into from
Closed

[RLlib] Fix some flakey CI tests. #47729

wants to merge 2 commits into from

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Sep 18, 2024 •
edited
Loading

Fix some flakey CI tests.

  • Connector example MeanStdFilter + PPO
  • 2 tests in test_learner_group.py

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
90a49a1 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) September 18, 2024 09:35
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 18, 2024
simonsays1980
simonsays1980 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rllib/core/learner/learner.py
@@ -1441,6 +1440,16 @@ def after_gradient_based_update(self, *, timesteps: Dict[str, Any]) -> None:
`NUM_ENV_STEPS_SAMPLED_LIFETIME`.
# TODO (sven): Make this a more formal structure with its own type.
"""
# Log total loss accross all modules.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the single loss terms are still stored in the (mid, "total_loss") keys, correct? I think its important to see which module contributes how much to the total loss.

@sven1977
fix
f3fce5f 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) September 18, 2024 11:01
@sven1977 sven1977 closed this Sep 19, 2024
auto-merge was automatically disabled September 19, 2024 12:13

Pull request was closed

@sven1977 sven1977 deleted the stabilize_some_rllib_ci_tests branch September 19, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980