Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][logging] Remove actor/task prefix from the logs shown on the driver process #47703

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Sep 17, 2024

Why are these changes needed?

  • With this PR
    image

  • Without this PR
    image

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: kaihsun <[email protected]>
@property
def get_job_logging_config(self):
"""Get the job's logging config for this worker"""
if not hasattr(self, "core_worker"):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a test case like test_namespace_validation, ray.init() throws an exception (code) before initializing the core_worker. As a result, when the test calls ray.shutdown, which also calls get_job_logging_config, the core_worker doesn't exist.

@kevin85421 kevin85421 marked this pull request as ready for review September 17, 2024 08:11
Signed-off-by: kaihsun <[email protected]>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Sep 17, 2024
python/ray/_private/worker.py Outdated Show resolved Hide resolved
python/ray/_private/worker.py Outdated Show resolved Hide resolved
Signed-off-by: kaihsun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants