Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix parallelism deriving heuristic to ensure parallelism stays w/in min/max bounds #47695

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexeykudinkin
Copy link
Contributor

Why are these changes needed?

Currently, min/max parallelism isn't actually being enforced correctly -- for large enough clusters we will be scaling out too aggressively purely based on the # of available CPUs disregarding the target block-sizes.

This change

  • Fixes parallelism detection heuristic to appropriately respect min/target block-sizes
  • Makes block-sizes configs' defaults env-var-configurable
  • Adjusts default min-block-size from 1Mb to 16Mb

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

… for parallelism based on target block-sizes

Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants