Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added azureai client #36

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

VindyaKonjarla
Copy link

No description provided.

@xieus xieus requested a review from avnishn February 24, 2024 21:43
README.md Outdated
### AzureAI Compatible APIs
```bash
export AZUREAI_API_KEY=secret_abcdefg
export AZUREAI_API_BASE="https://api.endpoints.anyscale.com/v1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an example Azure AI endpoint instead of an anyscale endpoint?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the API_BASE to .ai.azure.com

Signed-off-by: VindyaKonjarla <[email protected]>
@NicolasGrosjeanProbayes

Is it normal there is no difference compared to OpenAIChatCompletionsClient except the name of used environment variables ?

Note : OPENAI_API_BASE and OPENAI_API_KEY were not renamed in the ValueError

Signed-off-by: Sameep Kumar Panigrahi <[email protected]>
@VindyaKonjarla
Copy link
Author

VindyaKonjarla commented Mar 14, 2024

Is it normal there is no difference compared to OpenAIChatCompletionsClient except the name of used environment variables ?

Note : OPENAI_API_BASE and OPENAI_API_KEY were not renamed in the ValueError

@NicolasGrosjeanProbayes , Updated the file for the ValueError. Please review.And on your question, that is expected.

@NicolasGrosjeanProbayes

@NicolasGrosjeanProbayes , Updated the file for the ValueError. Please review.And on your question, that is expected.

I am a simple user, I have no write access, so my review will bring nothing.

I don't see the added value compared to OpenAI Compatible API if the code is the same.

Maybe I don't see the need to have the parameters in AZUREAI_API_KEY and AZUREAI_API_BASE variables instead of OPENAI_API_BASE and OPENAI_API_KEY variables. But even with this need, copying one hundred line of code doesn't seem a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants