[Fix] Fix Errors When Creating RayCluster via Direct CR Without Specifying HostPath type #3965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figured HostPath.Type
|
@owenowenisme Thank you for the reminder, I have already rebased. Related PR #3958 |
|
@owenowenisme Hi, could you help review my pull request when you have a minute? Your input would be really appreciated. No rush at all—just let me know if you need any context. Thanks! If it's handled by other colleagues, please let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make it compatible with the scenario where the user does not explicitly configure HostPath.Type, treating "type not specified" as HostPathFile, consistent with the behavior in the API server. This change will enhance the robustness and fault tolerance of the code.
Related issue number
Closes #3957
Checks