Skip to content

[Feature][APIServer v2] Support Compute Template in APIServer v2 #3959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

machichima
Copy link
Contributor

Why are these changes needed?

APIServer v1 introduced a unique and mandatory feature, Compute Template, which requires users to predefine the amount of CPU and memory resources they need in templates.

APIServer v2 doesn’t require users to predefine templates anymore, but we still want to continue supporting the feature to help v1 users migrate to v2 more easily.

Implementation

  1. Unmarshal the incoming request body in a new apiserversdk proxy handler.
  2. Extract computeTemplate from the headGroupSpec and workerGroupSpec.
  3. Mutate the request body according to the template before marshaling back.

We need 3 new proxy handlers for RayCluster, RayJob, and RayService, respectively. They may be able to share some parts of the implementation.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant