[Refactor][kubectl-plugin] Share common struct for cluster-related CLI options to reduce duplication #3719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, both
SubmitJobOptions
andCreateWorkerGroupOptions
structs contain many overlapping fields related to Ray cluster configuration, such as resource specs (CPU, GPU, memory), image, version, and selectors.Maintaining these separately leads to duplicated code and increases the risk of inconsistency when updating argument definitions.
KubectlPluginCommonOptions
inkubectl-plugin/pkg/util/types.go
SubmitJobOptions
andCreateWorkerGroupOptions
.The following element has been moved to
kubectl-plugin/pkg/util/types.go
Related issue number
Closes #3582
Checks