fix operator: show resource limit values in RayCluster.Status #3118
+105
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
force-pushed
the
dxia/patch331
branch
from
9a5e726 to
6734d31
Compare
davidxia
commented
Feb 26, 2025
Comment on lines
-454
to
+459
| containerResource := container.Resources.Requests | ||
| containerResource := container.Resources.Limits | ||
| if containerResource == nil { | ||
| containerResource = corev1.ResourceList{} | ||
| } | ||
| for name, quantity := range container.Resources.Limits { | ||
| for name, quantity := range container.Resources.Requests { |
There was a problem hiding this comment.
the important change
| @@ -841,3 +842,58 @@ func TestIsGCSFaultToleranceEnabled(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestCalculatePodResource(t *testing.T) { | |||
davidxia
force-pushed
the
dxia/patch331
branch
from
6734d31 to
07d2c88
Compare
instead of resource request values to be consistent with [these docs]. > On the other hand CPU, GPU, and memory **requests** will be ignored by Ray. For > this reason, it is best when possible to **set resource requests equal to > resource limits**. Also make `"nvidia.com/gpu"` and `"google.com/tpu"` into shared constants. [these docs]: https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/config.html#resources:~:text=On%20the%20other%20hand%20CPU%2C%20GPU%2C%20and%20memory%20requests%20will%20be%20ignored%20by%20Ray.%20For%20this%20reason%2C%20it%20is%20best%20when%20possible%20to%20set%20resource%20requests%20equal%20to%20resource%20limits. Signed-off-by: David Xia <[email protected]>
davidxia
force-pushed
the
dxia/patch331
branch
from
07d2c88 to
e23b164
Compare
davidxia
commented
Feb 27, 2025
There was a problem hiding this comment.
Looks like Volcano depends on the requests not limits? Seems like this goes against KubeRay best practices?
On the other hand CPU, GPU, and memory requests will be ignored by Ray. For this reason, it is best when possible to set resource requests equal to resource limits.
Is this a breaking change that cannot be made?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of resource request values to be consistent with these docs.
Also make
"nvidia.com/gpu"and"google.com/tpu"into shared constants.Checks