Included HermesIntentService. Changes to HermesBroadcastReceiver.#2
Included HermesIntentService. Changes to HermesBroadcastReceiver.#2sahildave wants to merge 2 commits intoraveeshbhalla:masterfrom
Conversation
sahildave
commented
May 15, 2015
sahildave
commented
- Moved all the message processing to abstract IntentService.
- Changed HermesBroadcastReceiver to WakefulBroadcastReceiver
- Added minor logger
- Updated build tools and support libs
…oadcastReceiver to WakefulBroadcastReceiver
There was a problem hiding this comment.
I'm a n00b when it comes to annotations. Can you explain the benefits of this vs a regular Log, other than typing down a tag each and every time?
There was a problem hiding this comment.
Yup it is basically for easier logging. Have been using loggers like Hugo and Timber so have the habit of cleaner logging. Helps in maintaining log tags etc.
The annotation is to suppress the lint warning of long log tags.
There was a problem hiding this comment.
I'll be having a look at the entire pull request later at night. I would, however, be leaving out Utils and logging the way you've done it, since my preference is to leave as many things to be on platform standards vs personal programming styles for open source projects. For eg, Utils is a common class name and might show up as an option when a bunch of users try importing their own classes. Easier to just avoid the entire thing.
There was a problem hiding this comment.
Yup, correct. I had first untracked the Utils file in git and made the commit but thought that the logging would become confusing. Would change it to regular logging.
|
Sorry about not looking into this, taking out some time later today |
2 participants
