-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fill ErrorReason and Remediation during verifierReport generation #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
requested review from
akashsinghal,
jimmyraywv,
luisdlp,
susanshi and
toddysm
as code owners
August 2, 2024 13:32
binbin-li
force-pushed
the
clean-up-reports
branch
from
August 2, 2024 14:17
75fb62e
to
ca94540
Compare
Codecov ReportAttention: Patch coverage is
|
binbin-li
force-pushed
the
clean-up-reports
branch
from
August 3, 2024 13:57
ca94540
to
1b862ca
Compare
binbin-li
force-pushed
the
clean-up-reports
branch
from
August 4, 2024 13:23
1b862ca
to
b743d51
Compare
binbin-li
changed the title
[DO NOT REVIEW] feat: fill ErrorReason and Remediation during verifierReport generation
feat: fill ErrorReason and Remediation during verifierReport generation
Aug 6, 2024
binbin-li
force-pushed
the
clean-up-reports
branch
from
August 9, 2024 12:37
382227e
to
cbc4587
Compare
susanshi
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some questions. thanks @binbin-li .
binbin-li
force-pushed
the
clean-up-reports
branch
from
August 13, 2024 03:02
9b753d6
to
fda9dfc
Compare
binbin-li
force-pushed
the
clean-up-reports
branch
from
August 13, 2024 03:10
daaf5df
to
a175d9e
Compare
akashsinghal
approved these changes
Aug 20, 2024
duffney
pushed a commit
to duffney/ratify
that referenced
this pull request
Aug 23, 2024
akashsinghal
pushed a commit
to akashsinghal/ratify
that referenced
this pull request
Sep 13, 2024
…on (ratify-project#1682) Signed-off-by: akashsinghal <[email protected]>
binbin-li
added a commit
to binbin-li/ratify
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
Message
and addErrorReason
andRemediation
in all returnedverifierResult
.VerifierName
andVerifierType
fields inverifierResult
to replaceName
and `Type in next major release.Example:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change