Bazel build implementation, doesn't provide options for the compilation modes opt and debug #2395
Conversation
|
ping @armandomontanez for his thoughts / review |
| @@ -294,3 +294,13 @@ label_flag( | |||
| name = "PICO_FREERTOS_LIB", | |||
| build_setting_default = "//bazel:empty_cc_lib", | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Please add docstrings above these and add them to the exclusion list in BAZEL_ONLY_ALLOWLIST here.
There was a problem hiding this comment.
Ok, Thanks. These have been added.
bazel/toolchain/BUILD.bazel
Outdated
| @@ -134,16 +152,27 @@ configurable_toolchain_feature( | |||
|
|
|||
| # TODO: Make this shim unnecessary. | |||
There was a problem hiding this comment.
These shims aren't necessary anymore, you can just directly list opt_args and debug_args in the cc_feature rules.
There was a problem hiding this comment.
Ok, Thanks. You are right, they weren't needed. Removed
…didnt make much sense, nor work. Leaving these for completness and future addition
|
I have also added for completeness the same implementations for the fastbuild compilation mode, which is the default. Thanks |
| @@ -294,3 +294,21 @@ label_flag( | |||
| name = "PICO_FREERTOS_LIB", | |||
| build_setting_default = "//bazel:empty_cc_lib", | |||
| ) | |||
|
|
|||
| # PICO_BAZEL_CONFIG: PICO_COMPILATION_OPT_OVERRIDE, Override the default opt compilation mode arguments to none, type=bool, default=0, group=build | |||
There was a problem hiding this comment.
Perhaps it would make sense if I knew more about bazel, but IMHO "Override the default xxxxx arguments to none" sounds kinda weird?
There was a problem hiding this comment.
Your right, OVERRIDE could be replaced with something like REMOVE ?
Ideally I wanted to override the defaults with user defined replacements. But it quickly got beyond my bazel knowledge.
So I resorted to an override Boolean to remove the defaults, and then the user could optionally replace using
build: --copt="-Os" for example.
I'm good with changing it to REMOVE?
There was a problem hiding this comment.
I've got a commit ready to go, if PICO_COMPILATION_xxx_REMOVE_DEFS is better?
Fixes #2394
The Bazel toolchain implementation does not have default args for the compilation modes opt and debug
i,e --compilation_mode=dbg and --compilation_mode=opt
Also the rule "@pico-sdk//bazel/toolchain:override_debug" provides defaults of -Og and -g3, but these are enabled by default in the toolchains, and are not changed with the above bazel cmd line --compilation_mode
From the bazel docs the defaults for opt should be -O2 and -DNDEBUG
https://bazel.build/docs/user-manual#compilation-mode
I have added 2 boolean flags
//bazel/config:PICO_COMPILATION_DEBUG_OVERRIDE
//bazel/config:PICO_COMPILATION_OPT_OVERRIDE
These can be set to true ( default is False) which will then remove the defaults from the toolchain. the user can then provide their own args with the cmd line --copts="...."