ws2812 fixes #610
Open
ws2812 fixes #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pixel_grb << 8u` in `put_pixel` would shift out the `w` and set white to green, green to to red, red to blue and blue to 0.
lurch
reviewed
Feb 18, 2025
| @@ -123,7 +144,11 @@ int main() { | |||
| bool success = pio_claim_free_sm_and_add_program_for_gpio_range(&ws2812_program, &pio, &sm, &offset, WS2812_PIN, 1, true); | |||
| hard_assert(success); | |||
|
|
|||
| #if IS_800KHz | |||
| ws2812_program_init(pio, sm, offset, WS2812_PIN, 800000, IS_RGBW); | |||
There was a problem hiding this comment.
Perhaps it makes more sense to add e.g. #define WS2812_FREQUENCY 800000 and then pass that to ws2812_program_init, rather than adding a #if IS_800KHz section?
lurch
reviewed
Feb 18, 2025
| @@ -17,15 +17,19 @@ | |||
| * Take into consideration if your WS2812 is a RGB or RGBW variant. | |||
| * | |||
| * If it is RGBW, you need to set IS_RGBW to true and provide 4 bytes per | |||
| * pixel (Red, Green, Blue, White) and use urgbw_u32(). | |||
| * pixel (Red, Green, Blue, White) and use urgb_u32() or urgbw_u32(). | |||
There was a problem hiding this comment.
I can't tell why you've effectively removed support for urgbw_u32() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.