Skip to content

media: i2c: imx477: Add control of FSTROBE via module parameters #6945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rpi-6.12.y
Choose a base branch
from
+41 −0
Open

media: i2c: imx477: Add control of FSTROBE via module parameters #6945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions drivers/media/i2c/imx477.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ static int trigger_mode;
module_param(trigger_mode, int, 0644);
MODULE_PARM_DESC(trigger_mode, "Set vsync trigger mode: 1=source, 2=sink");

static int fstrobe_enable;
module_param(fstrobe_enable, int, 0644);
MODULE_PARM_DESC(fstrobe_enable, "Enable fstrobe signal");

static int fstrobe_cont_trig;
module_param(fstrobe_cont_trig, int, 0644);
MODULE_PARM_DESC(fstrobe_cont_trig, "Configure fstrobe to be one-shot (0) or continuous (1)");

static int fstrobe_width = 1;
module_param(fstrobe_width, int, 0644);
MODULE_PARM_DESC(fstrobe_width, "Set fstrobe pulse width in units of INCK");

static int fstrobe_delay;
module_param(fstrobe_delay, int, 0644);
MODULE_PARM_DESC(fstrobe_delay, "Set fstrobe delay from end all lines starting to expose and the start of the strobe pulse");

#define IMX477_REG_VALUE_08BIT 1
#define IMX477_REG_VALUE_16BIT 2

Expand Down Expand Up @@ -1791,6 +1807,8 @@ static int imx477_start_streaming(struct imx477 *imx477)
struct i2c_client *client = v4l2_get_subdevdata(&imx477->sd);
const struct imx477_reg_list *reg_list, *freq_regs;
const struct imx477_reg_list *extra_regs;
unsigned int fst_width;
unsigned int fst_mult;
int ret, tm;

if (!imx477->common_regs_written) {
Expand Down Expand Up @@ -1825,6 +1843,29 @@ static int imx477_start_streaming(struct imx477 *imx477)
return ret;
}

fst_width = max((unsigned int)fstrobe_width, 1U);
fst_mult = 1;

while (fst_width / fst_mult > 0xffff && fst_mult < 255)
fst_mult++;

fst_width /= fst_mult;

// FLASH_MD_RS
imx477_write_reg(imx477, 0x0c1A, IMX477_REG_VALUE_08BIT,
((fstrobe_cont_trig ? 1 : 0) << 0) | (1 << 1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!fstrobe_cont_trig, and !!fstrobe_enable below?

// FLASH_STRB_WIDTH
imx477_write_reg(imx477, 0x0c18, IMX477_REG_VALUE_16BIT, fst_width);
// FLASH_STRB_WIDTH adjust
imx477_write_reg(imx477, 0x0c12, IMX477_REG_VALUE_08BIT, fst_mult);
// FLASH_STRB_START_POINT
imx477_write_reg(imx477, 0x0c14, IMX477_REG_VALUE_16BIT, fstrobe_delay);
// FLASH_STRB_DLY_RS
imx477_write_reg(imx477, 0x0c16, IMX477_REG_VALUE_16BIT, 0);
// FLASH_TRIG_RS
imx477_write_reg(imx477, 0x0c1B, IMX477_REG_VALUE_08BIT,
fstrobe_enable ? 1 : 0);

/* Set on-sensor DPC. */
imx477_write_reg(imx477, 0x0b05, IMX477_REG_VALUE_08BIT, !!dpc_enable);
imx477_write_reg(imx477, 0x0b06, IMX477_REG_VALUE_08BIT, !!dpc_enable);
Expand Down