WIP: HDMI HPD debounce #5386
Open
WIP: HDMI HPD debounce #5386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some cables it has been observed that the hot plug detect line can bounce up and down, causing a storm of HPD events to userspace. Delay the message for hotplug assert so that userspace doesn't get stressed. Do not delay hotplug deassert as we must ensure that HPD going low for 100ms is reported for times such as an A/V receiver being turned on and needing to force an EDID reread. The HDMI spec says this pulse is a minimum of 100ms. Signed-off-by: Dave Stevenson <[email protected]>
|
@spl237 Once the CI workflows have done their thing, you should be able to do |
0x4248
suggested changes
Mar 21, 2023
| drm_connector_helper_hpd_irq_event(connector); | ||
| } | ||
|
|
||
| #define HPD_DEBOUNCE_DELAY_MS 2500 |
There was a problem hiding this comment.
Please dont put defines here instead place it near the top of the file
- #define HPD_DEBOUNCE_DELAY_MS 2500You can put it near line 121
#define HSM_MIN_CLOCK_FREQ 120000000
#define CEC_CLOCK_FREQ 40000
#define HDMI_14_MAX_TMDS_CLK (340 * 1000 * 1000)
+ #define HPD_DEBOUNCE_DELAY_MS 2500
/* bit field to force hotplug detection. bit0 = HDMI0 */
static int force_hotplug = 0;
module_param(force_hotplug, int, 0644);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debounce the HPD signal for those people with dodgy cables.
WIP as the second patch pushes the delay up to 2.5secs. 250ms should be sufficient in most cases and not cause a noticeable delay.