[Zylius]

No description provided.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 359f66fa-5b15-4b59-9668-f8b3c8820477

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[FluffyDiscord]

my tibits:

1. services_resetter should not be required, its not required in symfony itself
2. i dont like the runtime checks for existing interfaces, do it at DI compile time, container injection can then go away
3. shouldnt this also handle the kernel shutdown before exiting? shutdown has even listeners apps might use
4. i think event dispatcher could be nice here, right now you dont even know this, if event dispatcher service exists
5. i would remove the gc collect, it only slows down your worker, doesnt really help with anything, if you have a leak, this wont save you
6. collapse $call->isCancelled() check into single place

[FluffyDiscord]

see previous comment

[FluffyDiscord]

@Zylius other points are not relevant?

[Zylius]

@Zylius other points are not relevant?

We're talking about number two? So we either make this a bundle or have users manually inject compiler passes. I dont like this.

[Zylius]

Thank you @FluffyDiscord