Repository navigation
fix: support Symfony 6.4 - #5
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
roxblnfk
reviewed
Oct 19, 2026
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-version response behavior needs confirmation from the expanded CI matrix, whose results were unavailable for this review.
No open issues 🎉
What changed in this PR
Adds Symfony 6.4 support to the Rapira Symfony runtime while retaining support for Symfony 7.4 and 8.0.
Changes:
- Broadens dependency constraints and documents compatibility.
- Adapts response emission and tests for older Symfony APIs.
- Expands CI coverage across supported Symfony versions.
| File | Description |
|---|---|
| tests/Fixtures/file-response-compatibility.php | Filters vendor deprecations during lazy loading. |
| tests/Feature/DispatcherResponseTest.php | Tests temporary-file streaming where supported. |
| tests/Feature/DispatcherModeTest.php | Skips event-stream tests when unavailable. |
| tests/App/public/index.php | Suppresses vendor boot deprecations. |
| src/Internal/SapiResponse.php | Sends headers and content without closing host buffers. |
| src/Internal/ExchangeResponseEmitter.php | Removes reliance on newer temporary-file internals. |
| README.md | Documents Symfony 6.4 support. |
| composer.json | Allows Symfony 6.4 dependencies. |
| .github/workflows/testing.yml | Adds per-version Symfony dependency testing. |
Review effort: Balanced
roxblnfk
approved these changes
Oct 19, 2026
Zylius
force-pushed
the
fix/symfony-6.4-support
branch
from
October 20, 2026 08:22
20df5a8 to
dcc6726
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.