Repository navigation
Conversation
Dots and underscores were folded into `_`, so `X_Forwarded_For` or `X.Forwarded.For` landed on `HTTP_X_FORWARDED_FOR` and could pose as the real header — to trusted proxy handling too, since Symfony builds its headers from these params. In worker mode the host drops such fields before filling `$_SERVER`; in dispatcher mode it passes them through, so the factory now drops them itself. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
[A-Za-z0-9-]no longer reaches the server params, and so neither Laravel's headers: Symfony builds its header bag from them..is no longer folded into_:X_Forwarded_ForandX.Forwarded.Forused to land onHTTP_X_FORWARDED_FORand pose as the real header, trusted proxy handling included.Why?
In worker mode the host drops such fields before filling
$_SERVER(unsafe_field_names = "drop", the default); in dispatcher mode it passes them through, so the factory has to drop them itself to match. Same as rapira-rs/sdk-php's dispatcher factory does.Checklist