Repository navigation
Conversation
fix: leave the client's authority out of SERVER_NAME Behind a proxy on a unix socket, REMOTE_ADDR held the socket path or nothing, so trusted proxies matching on private subnets failed in Dispatcher mode while Worker mode trusted the proxy. The SAPI sets SERVER_NAME from the configured server name, which a dispatcher cannot see yet; the client's authority under that name passed a client value off as a server one. Without an authority the URI's host is the host's own synthesis, so it still fills SERVER_NAME for getHost() to fall back on. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
REMOTE_ADDR=127.0.0.1andREMOTE_PORT=0, as the Rapira SAPI sets them in Worker mode. Before, the socket path or nothing, so trusted proxies on private subnets behind nginx on a unix socket were trusted in Worker mode only.SERVER_NAMEis no longer taken from the client's authority, which the request still carries inHTTP_HOST. When the client sent no authority, the URI's host is synthesized by the host (listener address, or the configuredserver_nameon a unix socket), so it still fillsSERVER_NAMEandgetHost()keeps a host to fall back on.Why?
Ports rapira-rs/sdk-php#16. Taking the configured server name and port from the dispatcher is tracked in rapira-rs/sdk-php#17, pending rapira-rs/contract#7.
Checklist
Review notes
SERVER_NAMEoutright; here it stays for a request without an authority, because Symfony'sgetHost()falls back toSERVER_NAMEwhenHTTP_HOSTis missing, and on a unix listener nothing else would give it a host.