Skip to content

Enable stricter compiler warnings (-Wnon-virtual-dtor, -Woverloaded-virtual) #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxwbuckley wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Enable stricter compiler warnings (-Wnon-virtual-dtor, -Woverloaded-virtual) #2327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0059816
Enable stricter compiler warnings (-Wshadow, -Wnon-virtual-dtor, -Wov…
maxwbuckley Mar 22, 2026
b9091a9
Fix Doxygen @param names to match renamed parameters
maxwbuckley Mar 22, 2026
f9cde49
Merge remote-tracking branch 'origin/main' into enable-strict-compile…
maxwbuckley May 23, 2026
b444650
Enable -Wnon-virtual-dtor and -Woverloaded-virtual
maxwbuckley May 23, 2026
4feac3e
Merge remote-tracking branch 'origin/main' into enable-strict-compile…
maxwbuckley May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,12 @@ if(RMM_NVTX)
target_compile_definitions(rmm PUBLIC RMM_NVTX)
endif()

set(RMM_CXX_FLAGS -Wall -Werror -Wextra -Wsign-conversion -Wno-unknown-pragmas
-Wno-error=deprecated-declarations)
set(RMM_CXX_FLAGS -Wall -Werror -Wextra -Wnon-virtual-dtor -Woverloaded-virtual -Wsign-conversion
-Wno-unknown-pragmas -Wno-error=deprecated-declarations)
set(RMM_CUDA_FLAGS
-Werror=all-warnings
-Xcompiler=-Wall,-Werror,-Wextra,-Wsign-conversion,-Wno-error=deprecated-declarations)
-Xcompiler=-Wall,-Werror,-Wextra,-Wnon-virtual-dtor,-Woverloaded-virtual,-Wsign-conversion,-Wno-error=deprecated-declarations
)
target_compile_options(rmm PRIVATE "$<$<COMPILE_LANGUAGE:CXX>:${RMM_CXX_FLAGS}>"
"$<$<COMPILE_LANGUAGE:CUDA>:${RMM_CUDA_FLAGS}>")

Expand Down
8 changes: 5 additions & 3 deletions cpp/benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@
option(DISABLE_DEPRECATION_WARNING "Disable warnings generated from deprecated declarations." OFF)
option(PER_THREAD_DEFAULT_STREAM "Build with per-thread default stream" OFF)

set(RMM_BENCHMARKS_CXX_FLAGS -Wall -Werror -Wextra -Wsign-conversion -Wno-unknown-pragmas)
set(RMM_BENCHMARKS_CUDA_FLAGS -Werror=all-warnings
-Xcompiler=-Wall,-Werror,-Wextra,-Wsign-conversion)
set(RMM_BENCHMARKS_CXX_FLAGS -Wall -Werror -Wextra -Wnon-virtual-dtor -Woverloaded-virtual
-Wsign-conversion -Wno-unknown-pragmas)
set(RMM_BENCHMARKS_CUDA_FLAGS
-Werror=all-warnings
-Xcompiler=-Wall,-Werror,-Wextra,-Wnon-virtual-dtor,-Woverloaded-virtual,-Wsign-conversion)

if(PER_THREAD_DEFAULT_STREAM)
message(STATUS "RMM: Building benchmarks with per-thread default stream")
Expand Down
7 changes: 5 additions & 2 deletions cpp/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@
option(DISABLE_DEPRECATION_WARNING "Disable warnings generated from deprecated declarations." OFF)
option(CODE_COVERAGE "Enable generating code coverage with gcov." OFF)

set(RMM_TESTS_CXX_FLAGS -Wall -Werror -Wextra -Wsign-conversion -Wno-unknown-pragmas)
set(RMM_TESTS_CUDA_FLAGS -Werror=all-warnings -Xcompiler=-Wall,-Werror,-Wextra,-Wsign-conversion)
set(RMM_TESTS_CXX_FLAGS -Wall -Werror -Wextra -Wnon-virtual-dtor -Woverloaded-virtual
-Wsign-conversion -Wno-unknown-pragmas)
set(RMM_TESTS_CUDA_FLAGS
-Werror=all-warnings
-Xcompiler=-Wall,-Werror,-Wextra,-Wnon-virtual-dtor,-Woverloaded-virtual,-Wsign-conversion)

include(rapids-test)
rapids_test_init()
Expand Down
Loading