feat(codegen): add typed exporter options to bindings - #499
Merged
Conversation
johanpel
marked this pull request as ready for review
July 31, 2026 09:01
johanpel
requested review from
9prady9,
cmatzenbach,
dhruv9vats,
felipeblazing,
johallar,
joosthooz and
mbrobbel
as code owners
July 31, 2026 09:01
johanpel
removed request for
cmatzenbach,
dhruv9vats,
felipeblazing,
johallar,
joosthooz and
mbrobbel
July 31, 2026 09:17
dhruv9vats
approved these changes
Jul 31, 2026
Contributor
Author
|
/merge |
9prady9
reviewed
Jul 31, 2026
9prady9
left a comment
9prady9
left a comment
Contributor
There was a problem hiding this comment.
seems fine, sorry for the late submission
kevkrist
pushed a commit
to kevkrist/sirius
that referenced
this pull request
Jul 31, 2026
## Summary Add configurable Quent telemetry exporters and use postcard for the default TPC-H benchmark configuration. ## Changes - Add `sirius.telemetry.exporter` configuration support for `ndjson`, `msgpack`, and `postcard`. - Configure the TPC-H benchmark telemetry YAML to use `postcard`. - Update Quent to upstream commit `2a5ca834`, which includes typed exporter options from rapidsai/quent#499. - Update Sirius’ Quent analyzer integration for upstream API changes. - Add `pnpm` to the Pixi environment, required to build the Quent UI. - Document exporter configuration and postcard usage for CI and benchmark runs. ## Testing - `pixi run make release` - `pixi run cargo check --manifest-path rust/Cargo.toml` - `pixi run cargo fmt --all --manifest-path rust/Cargo.toml --check` - `pixi run build/release/extension/sirius/test/cpp/sirius_unittest "[telemetry_context]"` - Ran TPC-H SF1 query 18 with `exporter: postcard`. - Opened the resulting telemetry with the Quent UI and verified it loads successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace string-based exporter selection in generated C++ and Python bindings with typed
ExporterOptionsfactories for no-op, NDJSON, MessagePack, Postcard, and collector exporters.This change also:
Related Issues
Closes #498
Testing
cargo fmt --all -- --checkcargo test -p quent-codegen -p quent-io-collectorcargo clippy --all-targets -- -D warningsrumdl checkon updated documentationWritten by Codex.